Skip to content

Commit 917829a

Browse files
committed
Corrected post create command syntax and updated documentation.
Signed-off-by: davem-bis <68955845+davem-bis@users.noreply.github.com>
1 parent 2276b3b commit 917829a

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "SQLMesh Dev",
2+
"name": "SQLMesh Python Dev",
33
"image": "mcr.microsoft.com/devcontainers/base:ubuntu-24.04",
44
"features": {
55
"ghcr.io/devcontainers/features/common-utils:2": {},

.devcontainer/post-create-command.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# This script is intended to be run by an Ubuntu dev container
44

55
# Install OS-level dependencies
6-
$ALL_DEPENDENCIES = "libpq-dev netcat-traditional unixodbc-dev default-jdk msodbcsql18 libodbc"
6+
ALL_DEPENDENCIES="libpq-dev netcat-traditional unixodbc-dev default-jdk msodbcsql18"
77

88
sudo apt-get clean && sudo apt-get -y update && sudo ACCEPT_EULA='Y' apt-get -y install $ALL_DEPENDENCIES
99

docs/development.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ Before you begin, ensure you have the following installed on your machine. Exact
1616
The development environment of SQLMesh depends both on:
1717

1818
* Python functionality (e.g. `SIGUSR1`) that is only available on UNIX systems, and;
19-
* Symbolic links, which whilst available on Windows, are more involved that on Linux or MacOS.
19+
* Symbolic links in the repository which, whilst available on Windows, typically require additional permissions for the process running git.
2020

2121
For the Python functionality, a dev container is provided to develop against Ubuntu 24 with Python 3.12.
2222

23-
For symbolic links, you must ensure that:
23+
For symbolic links, you must ensure that when checking out the repository:
2424

2525
- The git configuration `core.symlinks` is set to `true`
26-
- The process that git runs as is permitted to create symbolic links. This can be done via running git as an administrator, or enabling developer mode on Windows.
26+
- The process that git runs as is permitted to create symbolic links. This can typically be done by running git as an administrator, or enabling [developer mode on Windows](https://learn.microsoft.com/en-us/windows/advanced-settings/developer-mode).
2727

2828
## Virtual environment setup
2929

0 commit comments

Comments
 (0)