Skip to content

Commit 98f73de

Browse files
committed
DRAFT compiler support U24.04
on-going draft with compiler support U24.04 Signed-off-by: SaeHie Park <[email protected]>
1 parent 56ae25a commit 98f73de

File tree

19 files changed

+114
-100
lines changed

19 files changed

+114
-100
lines changed

.github/workflows/run-onecc-build.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,14 @@ jobs:
4545
strategy:
4646
matrix:
4747
type: [ Debug, Release ]
48-
ubuntu_code: [ focal, jammy ]
48+
ubuntu_code: [ focal, jammy ] #, noble ]
4949
include:
5050
- ubuntu_code: focal
5151
ubuntu_ver: 20.04
5252
- ubuntu_code: jammy
5353
ubuntu_ver: 22.04
54+
#- ubuntu_code: noble
55+
# ubuntu_ver: 24.04
5456
runs-on: one-x64-linux
5557
container:
5658
image: nnfw/one-devtools:${{ matrix.ubuntu_code }}
@@ -67,9 +69,15 @@ jobs:
6769
# dalgona uses pybind11, but pybind11 cannot bind packages in virtualenv.
6870
# So we need to install packages for dalgona-test globally.
6971
- name: Install required packages
72+
if: ${{ matrix.ubuntu_code == 'focal' || matrix.ubuntu_code == 'jammy' }}
7073
run: |
7174
python3 -m pip install numpy h5py==3.11.0 flatbuffers==23.5.26
7275
76+
- name: Install required packages
77+
if: ${{ matrix.ubuntu_code == 'noble' }}
78+
run: |
79+
apt-get install -y python3-numpy python3-h5py python3-flatbuffers
80+
7381
- name: Caching externals
7482
uses: actions/cache@v4
7583
with:
@@ -79,7 +87,7 @@ jobs:
7987
external-onecc-
8088
external-
8189
82-
- name: Caching externals
90+
- name: Caching overlay
8391
uses: actions/cache@v4
8492
with:
8593
path: ${{ env.NNCC_WORKSPACE }}/overlay

.github/workflows/run-onert-android-build.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,6 @@ on:
2121
- master
2222
- release/*
2323
paths:
24-
- '.github/workflows/run-onert-android-build.yml'
25-
- 'nn*'
26-
- 'Makefile.template'
27-
- 'infra/buildtool/**'
28-
- 'infra/cmake/**'
29-
- 'infra/nncc/**'
30-
- 'infra/nnfw/**'
3124
- 'runtime/**'
3225
- '!runtime/contrib/**'
3326
- '!**/*.md'

.github/workflows/run-onert-cross-build.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,6 @@ on:
2121
- master
2222
- release/*
2323
paths:
24-
- '.github/workflows/run-onert-cross-build.yml'
25-
- 'nn*'
26-
- 'Makefile.template'
27-
- 'infra/buildtool/**'
28-
- 'infra/cmake/**'
29-
- 'infra/nncc/**'
30-
- 'infra/nnfw/**'
3124
- 'runtime/**'
3225
- '!runtime/contrib/**'
3326
- '!**/*.md'

.github/workflows/run-onert-gbs-build.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,6 @@ on:
2424
- master
2525
- release/*
2626
paths:
27-
- '.github/workflows/run-onert-gbs-build.yml'
28-
- 'nncc'
29-
- 'nnfw'
30-
- 'compiler/luci/**'
31-
- 'compiler/loco/**'
32-
- 'compiler/logo/**'
33-
- 'compute/**'
34-
- 'infra/nnfw/**'
35-
- 'infra/cmake/**'
3627
- 'runtime/**'
3728
- '!runtime/contrib/**'
3829
- 'packaging/**'

.github/workflows/run-onert-native-build.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,6 @@ on:
2121
- master
2222
- release/*
2323
paths:
24-
- '.github/workflows/run-onert-native-build.yml'
25-
- 'nn*'
26-
- 'Makefile.template'
27-
- 'infra/buildtool/**'
28-
- 'infra/cmake/**'
29-
- 'infra/nncc/**'
30-
- 'infra/nnfw/**'
3124
- 'runtime/**'
3225
- '!runtime/contrib/**'
3326
- '!**/*.md'

compiler/CMakeLists.txt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
set(ONE_UBUNTU_CODENAME "focal")
44
find_program(LSB_RELEASE_EXEC lsb_release)
55
if(LSB_RELEASE_EXEC)
6-
# output should be one of 'bionic', 'focal', 'jammy'
6+
# output should be one of 'bionic', 'focal', 'jammy', 'noble'
77
# others are not tested
88
execute_process(COMMAND "${LSB_RELEASE_EXEC}" --short --codename
99
OUTPUT_VARIABLE ONE_UBUNTU_CODENAME
@@ -14,6 +14,10 @@ endif()
1414

1515
if(${ONE_UBUNTU_CODENAME} STREQUAL "bionic")
1616
set(ONE_UBUNTU_CODENAME_BIONIC TRUE)
17+
elseif(${ONE_UBUNTU_CODENAME} STREQUAL "focal")
18+
set(ONE_UBUNTU_CODENAME_FOCAL TRUE)
19+
elseif(${ONE_UBUNTU_CODENAME} STREQUAL "jammy")
20+
set(ONE_UBUNTU_CODENAME_JAMMY TRUE)
1721
elseif(${ONE_UBUNTU_CODENAME} STREQUAL "noble")
1822
set(ONE_UBUNTU_CODENAME_NOBLE TRUE)
1923
endif()

compiler/common-artifacts/CMakeLists.txt

Lines changed: 45 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ else()
2525
endif()
2626

2727
# tensorflow 2.12.1 supports Python 3.8 ~ 3.11
28-
if(Python_VERSION VERSION_GREATER_EQUAL 3.12)
29-
message(STATUS "Build common-artifacts: FALSE (Python version 3.12 or higher is not supported yet)")
30-
return()
31-
endif()
28+
#if(Python_VERSION VERSION_GREATER_EQUAL 3.12)
29+
# message(STATUS "Build common-artifacts: FALSE (Python version 3.12 or higher is not supported yet)")
30+
# return()
31+
#endif()
3232
if(Python_VERSION VERSION_LESS 3.8)
3333
message(STATUS "Build common-artifacts: FAILED (Install Python version 3.8 or 3.10)")
3434
return()
@@ -65,46 +65,53 @@ if(DEFINED ENV{ONE_PIP_OPTION_TRUST_HOST})
6565
set(PIP_OPTION_TRUSTED_HOST --trusted-host pypi.python.org --trusted-host files.pythonhosted.org --trusted-host pypi.org)
6666
endif()
6767

68+
set(PY_PKG_LIST )
6869
if(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
69-
# NOTE `tensorflow-cpu` package is not available for aarch64, so we use `tensorflow` package.
70-
add_custom_command(
71-
OUTPUT ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
72-
COMMAND ${CMAKE_COMMAND} -E remove -f ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
73-
COMMAND ${CMAKE_COMMAND} -E echo "tensorflow==2.12.1" >> ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
74-
COMMAND ${CMAKE_COMMAND} -E echo "flatbuffers==23.5.26" >> ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
75-
COMMAND ${CMAKE_COMMAND} -E echo "protobuf==4.23.3" >> ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
76-
COMMAND ${CMAKE_COMMAND} -E echo "pydot==1.4.2" >> ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
77-
COMMAND ${CMAKE_COMMAND} -E echo "pytest==7.4.3" >> ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
78-
COMMAND ${CMAKE_COMMAND} -E echo "h5py==3.11.0" >> ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
79-
COMMAND ${CMAKE_COMMAND} -E echo "cffi==1.16.0" >> ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
80-
COMMAND ${VIRTUALENV_OVERLAY_TF_2_12_1}/bin/${PYTHON_OVERLAY} -m pip --default-timeout=1000
81-
${PIP_OPTION_TRUSTED_HOST} install --upgrade pip setuptools
82-
COMMAND ${VIRTUALENV_OVERLAY_TF_2_12_1}/bin/${PYTHON_OVERLAY} -m pip --default-timeout=1000
83-
${PIP_OPTION_TRUSTED_HOST} install -r ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1} --upgrade
84-
DEPENDS ${VIRTUALENV_OVERLAY_TF_2_12_1}
85-
)
70+
list(APPEND PY_PKG_LIST "tensorflow==2.12.1")
71+
list(APPEND PY_PKG_LIST "flatbuffers==23.5.26")
72+
list(APPEND PY_PKG_LIST "protobuf==4.23.3")
73+
list(APPEND PY_PKG_LIST "pydot==1.4.2")
74+
list(APPEND PY_PKG_LIST "pytest==7.4.3")
75+
list(APPEND PY_PKG_LIST "h5py==3.11.0")
76+
list(APPEND PY_PKG_LIST "cffi==1.16.0")
8677
else(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
78+
list(APPEND PY_PKG_LIST "tensorflow==2.12.1")
79+
list(APPEND PY_PKG_LIST "flatbuffers==23.5.26")
80+
list(APPEND PY_PKG_LIST "protobuf==4.23.3")
81+
list(APPEND PY_PKG_LIST "pydot==1.4.2")
82+
list(APPEND PY_PKG_LIST "pytest==7.4.3")
83+
list(APPEND PY_PKG_LIST "h5py==3.11.0")
84+
list(APPEND PY_PKG_LIST "cffi==1.16.0")
85+
endif(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
86+
87+
add_custom_command(
88+
OUTPUT REQUIREMENTS_OVERLAY_PATH_TF_2_12_1_clean
89+
COMMAND ${CMAKE_COMMAND} -E remove -f ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
90+
DEPENDS ${VIRTUALENV_OVERLAY_TF_2_12_1}
91+
)
92+
93+
set(PY_PKG_LIST_DEPENDS_PREV REQUIREMENTS_OVERLAY_PATH_TF_2_12_1_clean)
94+
foreach(PKG_VER IN LISTS PY_PKG_LIST)
95+
message(STATUS "!!! ${PKG_VER}")
8796
add_custom_command(
88-
OUTPUT ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
89-
COMMAND ${CMAKE_COMMAND} -E remove -f ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
90-
COMMAND ${CMAKE_COMMAND} -E echo "tensorflow-cpu==2.12.1" >> ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
91-
COMMAND ${CMAKE_COMMAND} -E echo "flatbuffers==23.5.26" >> ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
92-
COMMAND ${CMAKE_COMMAND} -E echo "protobuf==4.23.3" >> ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
93-
COMMAND ${CMAKE_COMMAND} -E echo "pydot==1.4.2" >> ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
94-
COMMAND ${CMAKE_COMMAND} -E echo "pytest==7.4.3" >> ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
95-
COMMAND ${CMAKE_COMMAND} -E echo "h5py==3.11.0" >> ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
96-
COMMAND ${CMAKE_COMMAND} -E echo "cffi==1.16.0" >> ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
97-
COMMAND ${VIRTUALENV_OVERLAY_TF_2_12_1}/bin/${PYTHON_OVERLAY} -m pip --default-timeout=1000
98-
${PIP_OPTION_TRUSTED_HOST} install --upgrade pip setuptools
99-
COMMAND ${VIRTUALENV_OVERLAY_TF_2_12_1}/bin/${PYTHON_OVERLAY} -m pip --default-timeout=1000
100-
${PIP_OPTION_TRUSTED_HOST} install -r ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1} --upgrade
101-
DEPENDS ${VIRTUALENV_OVERLAY_TF_2_12_1}
97+
OUTPUT ${PKG_VER}_item
98+
COMMAND ${CMAKE_COMMAND} -E echo "${PKG_VER}" >> ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
99+
DEPENDS ${VIRTUALENV_OVERLAY_TF_2_12_1} ${PY_PKG_LIST_DEPENDS_PREV}
102100
)
103-
endif(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
101+
set(PY_PKG_LIST_DEPENDS_PREV ${PKG_VER}_item)
102+
endforeach()
103+
104+
add_custom_command(
105+
OUTPUT VIRTUALENV_OVERLAY_TF_2_12_1_installed
106+
COMMAND ${VIRTUALENV_OVERLAY_TF_2_12_1}/bin/${PYTHON_OVERLAY} -m pip --default-timeout=1000
107+
${PIP_OPTION_TRUSTED_HOST} install --upgrade pip setuptools
108+
COMMAND ${VIRTUALENV_OVERLAY_TF_2_12_1}/bin/${PYTHON_OVERLAY} -m pip --default-timeout=1000
109+
${PIP_OPTION_TRUSTED_HOST} install -r ${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1} --upgrade
110+
DEPENDS ${VIRTUALENV_OVERLAY_TF_2_12_1} ${PY_PKG_LIST_DEPENDS_PREV}
111+
)
104112

105113
add_custom_target(common_artifacts_python_deps ALL
106-
DEPENDS ${VIRTUALENV_OVERLAY_TF_2_12_1}
107-
${REQUIREMENTS_OVERLAY_PATH_TF_2_12_1}
114+
DEPENDS VIRTUALENV_OVERLAY_TF_2_12_1_installed
108115
)
109116

110117
#[[ Generate common resources ]]

compiler/dalgona/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# Ubuntu18.04; explictly installed python3.8 (default is python3.6)
33
# Ubuntu20.04; default python3.8
44
# Ubuntu22.04; default python3.10
5-
# Ubuntu24.04; explictly installed python3.8 (default is python3.12)
5+
# Ubuntu24.04; default python3.12
66
# refer https://github.com/Samsung/ONE/issues/9962
77
if(CMAKE_VERSION VERSION_LESS 3.12)
88
find_package(PythonInterp 3.8 QUIET)

compiler/fm-equalize-value-py-test/CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
message(STATUS "SKIP fm-equalize")
2+
return()
3+
14
if(NOT ENABLE_TEST)
25
return()
36
endif(NOT ENABLE_TEST)

compiler/mir/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ set(MIR_SOURCES
2929
add_library(mir STATIC ${MIR_SOURCES})
3030
target_include_directories(mir PUBLIC include)
3131
target_link_libraries(mir PUBLIC adtidas)
32-
target_link_libraries(mir PRIVATE nncc_common)
32+
# to prevent _GLIBCXX17_DEPRECATED warning as error
33+
# target_link_libraries(mir PRIVATE nncc_common)
3334
target_link_libraries(mir PUBLIC nncc_coverage)
3435

3536
set_target_properties(mir PROPERTIES POSITION_INDEPENDENT_CODE ON)

0 commit comments

Comments
 (0)