Skip to content

[mir] Disable nncc_common option #15256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

[mir] Disable nncc_common option #15256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion compiler/mir/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ set(MIR_SOURCES
add_library(mir STATIC ${MIR_SOURCES})
target_include_directories(mir PUBLIC include)
target_link_libraries(mir PUBLIC adtidas)
target_link_libraries(mir PRIVATE nncc_common)
# to prevent _GLIBCXX17_DEPRECATED warning as error
# target_link_libraries(mir PRIVATE nncc_common)
Copy link
Contributor

@shs-park shs-park Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we don't need nncc_common library anymore?
Is it okay to remove this library?

Copy link
Contributor Author

@seanshpark seanshpark Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not like "not needed anymore" but it's like "cannot use this option anymore".

nncc_common is to set strict build, like treating warning as error option.
to fix the issue correctly is not to use deprecated std::iterator,
but as mir and nncc modules are not maintained and not used anymore,
and I personally don't know the codes, I'm nust avoiding the problem.

Copy link
Collaborator

@jinevening jinevening Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I neither know those codes. Maybe we can remove mir and nnc if they are not maintained anymore?

target_link_libraries(mir PUBLIC nncc_coverage)

set_target_properties(mir PROPERTIES POSITION_INDEPENDENT_CODE ON)
Expand Down
4 changes: 3 additions & 1 deletion compiler/mir/src/mir_caffe2_importer/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,6 @@ set(MIR_CAFFE2_IMPORTER_SOURCES
add_library(mir_caffe2_importer STATIC ${MIR_CAFFE2_IMPORTER_SOURCES})
set_target_properties(mir_caffe2_importer PROPERTIES POSITION_INDEPENDENT_CODE ON)
target_include_directories(mir_caffe2_importer PUBLIC ../../include/mir_caffe2_importer)
target_link_libraries(mir_caffe2_importer PUBLIC mir PRIVATE caffe2proto nncc_common)
target_link_libraries(mir_caffe2_importer PUBLIC mir PRIVATE caffe2proto)
# to prevent _GLIBCXX17_DEPRECATED warning as error
# target_link_libraries(mir_caffe2_importer PRIVATE nncc_common)
4 changes: 3 additions & 1 deletion compiler/mir/src/mir_caffe_importer/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,6 @@ set(MIR_CAFFE_IMPORTER_SOURCES
add_library(mir_caffe_importer STATIC ${MIR_CAFFE_IMPORTER_SOURCES})
set_target_properties(mir_caffe_importer PROPERTIES POSITION_INDEPENDENT_CODE ON)
target_include_directories(mir_caffe_importer PUBLIC ../../include/mir_caffe_importer)
target_link_libraries(mir_caffe_importer PUBLIC mir PRIVATE caffeproto nncc_common)
target_link_libraries(mir_caffe_importer PUBLIC mir PRIVATE caffeproto)
# to prevent _GLIBCXX17_DEPRECATED warning as error
# target_link_libraries(mir_caffe_importer PRIVATE nncc_common)
4 changes: 3 additions & 1 deletion compiler/mir/src/mir_onnx_importer/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ add_library(mir_onnx_importer STATIC ${MIR_ONNX_IMPORTER_SOURCES})
set_target_properties(mir_onnx_importer PROPERTIES POSITION_INDEPENDENT_CODE ON)
target_include_directories(mir_onnx_importer PUBLIC ../../include/mir_onnx_importer)
target_include_directories(mir_onnx_importer PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})
target_link_libraries(mir_onnx_importer PUBLIC mir mir_onnx_proto PRIVATE mir_interpreter nncc_common)
target_link_libraries(mir_onnx_importer PUBLIC mir mir_onnx_proto PRIVATE mir_interpreter)
# to prevent _GLIBCXX17_DEPRECATED warning as error
# target_link_libraries(mir_onnx_importer PRIVATE nncc_common)

if(NOT ENABLE_TEST)
return()
Expand Down