fix(uninstall|scoop-uninstall): Fix incomplete self-uninstallation #6453
+220
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z-Fng
force-pushed
the
fix-self-uninstall
branch
3 times, most recently
from
84c392f to
5e96196
Compare
…nify uninstall flow for self and packages
z-Fng
force-pushed
the
fix-self-uninstall
branch
from
5e96196 to
31415b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the following changes:
Fix incomplete self-uninstallation, unify uninstall flow for self and apps.Motivation and Context
Closes #6447
How Has This Been Tested?
I've tested this locally. I'm not sure if adding a test case is necessary.
Checklist:
developbranch.