fix: properly handle ignore certificate on health check

Author: Kinue72

charts/signoz/templates/_clickhouse.tpl

@@ -89,6 +89,8 @@ Minimized ClickHouse ENV variables for user credentials
   value: {{ .Values.clickhouse.password | quote }}
 - name: CLICKHOUSE_SECURE
   value: {{ .Values.clickhouse.secure | quote }}
+- name: CLICKHOUSE_VERIFY
+  value: {{ .Values.clickhouse.verify | quote }}
 {{- else -}}
 - name: CLICKHOUSE_HOST
   value: {{ required "externalClickhouse.host is required if not clickhouse.enabled" .Values.externalClickhouse.host | quote }}
@@ -112,6 +114,8 @@ Minimized ClickHouse ENV variables for user credentials
 {{- end }}
 - name: CLICKHOUSE_SECURE
   value: {{ .Values.externalClickhouse.secure | quote }}
+- name: CLICKHOUSE_VERIFY
+  value: {{ .Values.externalClickhouse.verify | quote }}
 {{- end }}
 {{- end }}
 

charts/signoz/templates/_helpers.tpl

@@ -493,6 +493,13 @@ imagePullSecrets:
 {{- end }}
 {{- end }}
 
+{{/*
+Generate --no-check-certificate flag based on CLICKHOUSE_VERIFY environment variable
+*/}}
+{{- define "wget.clickhouse.noVerifyFlag" -}}
+$(if [ "${CLICKHOUSE_VERIFY}" = "false" ]; then echo "--no-check-certificate"; fi)
+{{- end -}}
+
 
 {{/* 
 Create Env

charts/signoz/templates/otel-collector/deployment.yaml

@@ -82,7 +82,7 @@ spec:
           command:
             - sh
             - -c
-            - until wget --user "${CLICKHOUSE_USER}:${CLICKHOUSE_PASSWORD}" --spider -q {{ include "clickhouse.httpUrl" $ }}{{ .endpoint }}; do echo -e "{{ .waitMessage }}"; sleep {{ .delay }}; done; echo -e "{{ .doneMessage }}";
+            - until wget {{ include "wget.clickhouse.noVerifyFlag" $ }} --user "${CLICKHOUSE_USER}:${CLICKHOUSE_PASSWORD}" --spider -q {{ include "clickhouse.httpUrl" $ }}{{ .endpoint }}; do echo -e "{{ .waitMessage }}"; sleep {{ .delay }}; done; echo -e "{{ .doneMessage }}";
           {{- end }}
           resources:
             {{- toYaml .Values.otelCollector.initContainers.init.resources | nindent 12 }}

charts/signoz/templates/schema-migrator/migrations-async.yaml

@@ -43,7 +43,7 @@ spec:
           command:
             - sh
             - -c
-            - until wget --user "$(CLICKHOUSE_USER):$(CLICKHOUSE_PASSWORD)" --spider -q {{ include "clickhouse.httpUrl" $ }}{{ .endpoint }}; do echo -e "{{ .waitMessage }}"; sleep {{ .delay }}; done; echo -e "{{ .doneMessage }}";
+            - until wget {{ include "wget.clickhouse.noVerifyFlag" $ }} --user "$(CLICKHOUSE_USER):$(CLICKHOUSE_PASSWORD)" --spider -q {{ include "clickhouse.httpUrl" $ }}{{ .endpoint }}; do echo -e "{{ .waitMessage }}"; sleep {{ .delay }}; done; echo -e "{{ .doneMessage }}";
           {{- end }}
           resources:
             {{- toYaml .Values.schemaMigrator.initContainers.init.resources | nindent 12 }}

charts/signoz/templates/schema-migrator/migrations-sync.yaml

@@ -42,7 +42,7 @@ spec:
           command:
             - sh
             - -c
-            - until wget --user "$(CLICKHOUSE_USER):$(CLICKHOUSE_PASSWORD)" --spider -q {{ include "clickhouse.httpUrl" $ }}{{ .endpoint }}; do echo -e "{{ .waitMessage }}"; sleep {{ .delay }}; done; echo -e "{{ .doneMessage }}";
+            - until wget {{ include "wget.clickhouse.noVerifyFlag" $ }} --user "$(CLICKHOUSE_USER):$(CLICKHOUSE_PASSWORD)" --spider -q {{ include "clickhouse.httpUrl" $ }}{{ .endpoint }}; do echo -e "{{ .waitMessage }}"; sleep {{ .delay }}; done; echo -e "{{ .doneMessage }}";
           {{- end }}
           resources:
             {{- toYaml .Values.schemaMigrator.initContainers.init.resources | nindent 12 }}

charts/signoz/templates/signoz/statefulset.yaml

@@ -61,7 +61,7 @@ spec:
           command:
             - sh
             - -c
-            - until wget --user "${CLICKHOUSE_USER}:${CLICKHOUSE_PASSWORD}" --spider -q {{ include "clickhouse.httpUrl" $ }}{{ .endpoint }}; do echo -e "{{ .waitMessage }}"; sleep {{ .delay }}; done; echo -e "{{ .doneMessage }}";
+            - until wget {{ include "wget.clickhouse.noVerifyFlag" $ }} --user "${CLICKHOUSE_USER}:${CLICKHOUSE_PASSWORD}" --spider -q {{ include "clickhouse.httpUrl" $ }}{{ .endpoint }}; do echo -e "{{ .waitMessage }}"; sleep {{ .delay }}; done; echo -e "{{ .doneMessage }}";
           {{- end }}
           resources:
             {{- toYaml .init.resources | nindent 12 }}