Skip to content

Conversation

@srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Nov 10, 2025

📄 Summary

Fixes #9536


Note

Adds severity and lastSeen labels to threshold alert outputs and context link presets, and standardizes threshold name constants to lowercase (critical/error/warning/info).

  • Alerts/Rules:
    • Append severity label (lowercased threshold name) to alert samples in ruletypes.BasicRuleThreshold.shouldAlert.
    • Use ruletypes.LabelLastSeen when emitting no-data alerts in threshold_rule.go.
    • Add/standardize constants in ruletypes/constants.go: lowercase threshold names and new label keys (severity, lastSeen).
  • Context Links:
    • Expand PredefinedAlertLabels to include severity and lastSeen.
  • Tests:
    • Update threshold_test.go to use new constants and assert presence of severity label.

Written by Cursor Bugbot for commit 0921931. This will update automatically on new commits. Configure here.

@github-actions github-actions bot added the bug Something isn't working label Nov 10, 2025
@srikanthccv srikanthccv marked this pull request as ready for review November 11, 2025 14:46
@srikanthccv srikanthccv merged commit 9f089e0 into main Nov 12, 2025
15 checks passed
@srikanthccv srikanthccv deleted the issue-9536 branch November 12, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event object is invalid: 'payload.severity' is missing or blank

2 participants