Fix flaky test

henryju · henryju · commit 61530c21bbef · 2024-12-19T18:01:50.000+01:00
diff --git a/lib/src/test/java/org/sonarsource/scanner/lib/internal/facade/forked/JavaRunnerTest.java b/lib/src/test/java/org/sonarsource/scanner/lib/internal/facade/forked/JavaRunnerTest.java
@@ -72,7 +72,7 @@ void execute_whenInvalidRunner_shouldFail() {
   void execute_shouldReturnFalseWhenNonZeroExitCode() {
     JavaRunner runner = new JavaRunner(Paths.get("java"), JreCacheHit.DISABLED);
     List<String> command = List.of("unknown-command");
-    assertThat(runner.execute(command, "test", stdOut::add)).isFalse();
+    assertThat(runner.execute(command, null, stdOut::add)).isFalse();
   }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ void execute_whenInvalidRunner_shouldFail() {`
`72`	`72`	`void execute_shouldReturnFalseWhenNonZeroExitCode() {`
`73`	`73`	`JavaRunner runner = new JavaRunner(Paths.get("java"), JreCacheHit.DISABLED);`
`74`	`74`	`List<String> command = List.of("unknown-command");`
`75`		`- assertThat(runner.execute(command, "test", stdOut::add)).isFalse();`
	`75`	`+ assertThat(runner.execute(command, null, stdOut::add)).isFalse();`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`}`