Skip to content

Commit 34e99fb

Browse files
committed
fix(thresholds): add observed threshold for attribute 188 with value 0 (upstream PR AnalogJ#551)
Adds an observed threshold entry for ATA attribute 188 (Command_Timeout) when the value is exactly 0. This fixes incorrect failure rate calculations for drives with zero command timeouts, particularly affecting Seagate drives. Related to issues with Seagate Command Timeout display (AnalogJ#799). Origin: AnalogJ#551 Original author: @aivus
1 parent df7da88 commit 34e99fb

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

webapp/backend/pkg/thresholds/ata_attribute_metadata.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -692,6 +692,12 @@ var AtaMetadata = map[int]AtaAttributeMetadata{
692692
return rawValue
693693
},
694694
ObservedThresholds: []ObservedThreshold{
695+
{
696+
Low: 0,
697+
High: 0,
698+
AnnualFailureRate: 0.024893587674442153,
699+
ErrorInterval: []float64{0.020857343769186413, 0.0294830350167543},
700+
},
695701
{
696702
Low: 0,
697703
// This is set arbitrarily to avoid notifications caused by low

0 commit comments

Comments
 (0)