fix(seo): stop publishing a rating nobody gave, on 26 pages (#11)

DatabaseClient.tsx derived an aggregateRating from the GitHub star count —
a constant ratingValue of 4.9 with ratingCount set to the stars — and shipped
it on every one of the 26 database pages.

Compare.tsx already refuses to do this, and says why in a docblock. There is
even a test named "never publishes a rating nobody gave". Its file list was
Home.tsx and Compare.tsx, so it passed for as long as the violation shipped.

The guard now enumerates the pages that emit a SoftwareApplication node from
the filesystem and fails when that set grows, rather than trusting a list
somebody has to remember to update. Running it that way immediately turned up
Download.tsx, a fourth emitter that had never been covered either.

Two smaller repairs to the same test:

- It matched only the quoted 'aggregateRating'. The property-assignment form
  this bug actually used, data.aggregateRating = {...}, was never matched.
- Matching the bare word made it fail on the docblocks that explain why the
  rating is absent, so comments are stripped before the needles run.

A structured-data manual action for fabricated reviews applies to the whole
site, so this does not wait behind the landing-page work.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Author: datlechin

resources/js/pages/DatabaseClient.tsx

@@ -19,7 +19,15 @@ interface Props {
     githubStars?: number | null;
 }
 
-function buildAppJsonLd(name: string, description: string, slug: string, stars?: number | null): object {
+/**
+ * No `aggregateRating`. This page used to derive one from the GitHub star count
+ * — a constant 4.9 with `ratingCount` set to the stars — on all 26 database
+ * pages. A star is not a review, so that published a rating nobody gave, and
+ * `Compare.tsx` already refuses to do it for the same reason. The guard in
+ * `StaleClaimsTest` was written to catch exactly this and did not list this
+ * file; it does now.
+ */
+function buildAppJsonLd(name: string, description: string, slug: string): object {
     const data: Record<string, unknown> = {
         '@context': 'https://schema.org',
         '@type': 'SoftwareApplication',
@@ -36,16 +44,6 @@ function buildAppJsonLd(name: string, description: string, slug: string, stars?:
         downloadUrl: 'https://tablepro.app/download',
     };
 
-    if (stars && stars > 0) {
-        data.aggregateRating = {
-            '@type': 'AggregateRating',
-            ratingValue: '4.9',
-            ratingCount: stars,
-            bestRating: '5',
-            worstRating: '1',
-        };
-    }
-
     return data;
 }
 
@@ -55,7 +53,7 @@ export default function DatabaseClient({ slug, downloadUrls, githubStars }: Prop
     if (!db) return null;
 
     const title = `${db.name} GUI Client for Mac - Free & Native | TablePro`;
-    const jsonLd: object[] = [buildAppJsonLd(db.name, db.description, db.slug, githubStars)];
+    const jsonLd: object[] = [buildAppJsonLd(db.name, db.description, db.slug)];
 
     if (db.faqs && db.faqs.length > 0) {
         jsonLd.push({

tests/Feature/Seo/StaleClaimsTest.php

@@ -60,13 +60,51 @@
 });
 
 it('never publishes a rating nobody gave', function () use ($readSource): void {
-    foreach (['resources/js/pages/Home.tsx', 'resources/js/pages/Compare.tsx'] as $source) {
-        $contents = $readSource($source);
+    /*
+     * Every page that emits a SoftwareApplication node, not just the two that
+     * were listed. DatabaseClient.tsx was absent for as long as it shipped
+     * `ratingValue: '4.9'` with `ratingCount` set to the GitHub star count, so
+     * this test passed while 26 indexed URLs published a fabricated rating.
+     *
+     * The list is asserted against the filesystem rather than hardcoded alone:
+     * a new page that builds a SoftwareApplication must be added here, and the
+     * count below is what forces that.
+     */
+    $sources = [
+        'resources/js/pages/Home.tsx',
+        'resources/js/pages/Compare.tsx',
+        'resources/js/pages/DatabaseClient.tsx',
+        'resources/js/pages/Download.tsx',
+    ];
 
-        // A rating derived from star counts, and a constant score applied to
-        // every competitor, are both inventions. Neither may come back.
-        expect($contents)
-            ->not->toContain("'aggregateRating'")
+    $emitters = array_values(array_filter(
+        glob(base_path('resources/js/pages/*.tsx')),
+        static fn(string $path): bool => str_contains(file_get_contents($path), "'SoftwareApplication'"),
+    ));
+
+    expect($emitters)->toHaveCount(
+        count($sources),
+        'A page started emitting a SoftwareApplication node. Add it to $sources above.',
+    );
+
+    foreach ($sources as $source) {
+        /*
+         * Comments stripped first. Two of these files carry a docblock saying
+         * why they do not publish a rating, and a bare `aggregateRating` needle
+         * matches the explanation as readily as the offence.
+         */
+        $code = preg_replace(['#/\*[\s\S]*?\*/#', '#//.*$#m'], '', $readSource($source));
+
+        /*
+         * A rating derived from star counts, and a constant score applied to
+         * every competitor, are both inventions. Neither may come back.
+         *
+         * `aggregateRating` is matched unquoted because the property-assignment
+         * form — `data.aggregateRating = {...}` — is how it actually shipped,
+         * and the quoted needle this test used to carry never matched it.
+         */
+        expect($code)
+            ->not->toContain('aggregateRating')
             ->not->toContain('AggregateRating')
             ->not->toContain('ratingValue');
     }