From 44e81c0fa43cc9da56c8fbdd0bf49773c6b41c70 Mon Sep 17 00:00:00 2001 From: Titus TC Date: Sat, 30 May 2026 19:51:54 +0300 Subject: [PATCH] HtmlRenderer: submit type for create and edit action buttons The action buttons rendered by HtmlRenderer only set type=submit for 'save'; 'create' and 'edit' fell through to type=button, so their forms never posted (e.g. the DataView 'Add New' create form was a dead button). route_plural already handles their POST submissions. Delete is left as a button since this renderer adds no confirm handler. --- src/Renderer/HtmlRenderer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Renderer/HtmlRenderer.php b/src/Renderer/HtmlRenderer.php index 149813f..7920dc2 100644 --- a/src/Renderer/HtmlRenderer.php +++ b/src/Renderer/HtmlRenderer.php @@ -189,7 +189,7 @@ protected function render_sidebar( array $sidebar ): string { * @return string The rendered HTML. */ protected function render_action( string $action ): string { - $type = ( $action === 'save' ) ? 'submit' : 'button'; + $type = in_array( $action, [ 'save', 'create', 'edit' ], true ) ? 'submit' : 'button'; $label = ucfirst( $action ); return '';