Commit 99c3437
authored
Fix Node Highlight on Task Hover (#1401)
## Description
<!-- Please provide a brief description of the changes made in this pull request. Include any relevant context or reasoning for the changes. -->
Fixes a bug where dragging from the component library over a node on the canvas to replace it would not highlight the replace-target node.
## Related Issue and Pull requests
<!-- Link to any related issues using the format #<issue-number> -->
Closes Shopify/oasis-frontend#326
## Type of Change
<!-- Please delete options that are not relevant -->
- [x] Bug fix
## Checklist
<!-- Please ensure the following are completed before submitting the PR -->
- [ ] I have tested this does not break current pipelines / runs functionality
- [ ] I have tested the changes on staging
## Screenshots (if applicable)
<!-- Include any screenshots that might help explain the changes or provide visual context -->
## Test Instructions
<!-- Detail steps and prerequisites for testing the changes in this PR -->
1. Drag a task from the library and hover over a node on the canvas, it should highlight orange.
2. It should un-highlight when you move off it
3. Replace flow should trigger if you release while it is highlighted
## Additional Comments
Future: disable highlighting when an IO node is dragged over a task
<!-- Add any additional context or information that reviewers might need to know regarding this PR -->1 parent 2927f0a commit 99c3437
File tree
1 file changed
+15
-4
lines changed1 file changed
+15
-4
lines changedLines changed: 15 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
575 | 575 | | |
576 | 576 | | |
577 | 577 | | |
578 | | - | |
579 | | - | |
| 578 | + | |
580 | 579 | | |
581 | 580 | | |
582 | 581 | | |
583 | 582 | | |
584 | | - | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
585 | 591 | | |
586 | 592 | | |
587 | 593 | | |
| |||
912 | 918 | | |
913 | 919 | | |
914 | 920 | | |
915 | | - | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
916 | 927 | | |
917 | 928 | | |
918 | 929 | | |
| |||
0 commit comments