style: Clean up debug aid

Co-authored-by: Alan Szepieniec <[email protected]>

Author: Sword-Smith

tasm-lib/benchmarks/tasmlib_verifier_stark_verify_inner_padded_height_256_fri_exp_4.json

@@ -2,11 +2,11 @@
   {
     "name": "tasmlib_verifier_stark_verify_inner_padded_height_256_fri_exp_4",
     "benchmark_result": {
-      "clock_cycle_count": 180166,
-      "hash_table_height": 123013,
-      "u32_table_height": 24954,
-      "op_stack_table_height": 167760,
-      "ram_table_height": 268641
+      "clock_cycle_count": 180190,
+      "hash_table_height": 123019,
+      "u32_table_height": 24881,
+      "op_stack_table_height": 167780,
+      "ram_table_height": 268644
     },
     "case": "CommonCase"
   }

tasm-lib/benchmarks/tasmlib_verifier_stark_verify_inner_padded_height_512_fri_exp_4.json

@@ -2,11 +2,11 @@
   {
     "name": "tasmlib_verifier_stark_verify_inner_padded_height_512_fri_exp_4",
     "benchmark_result": {
-      "clock_cycle_count": 188913,
-      "hash_table_height": 130705,
-      "u32_table_height": 33133,
-      "op_stack_table_height": 173884,
-      "ram_table_height": 269819
+      "clock_cycle_count": 188937,
+      "hash_table_height": 130711,
+      "u32_table_height": 33258,
+      "op_stack_table_height": 173904,
+      "ram_table_height": 269822
     },
     "case": "CommonCase"
   }

tasm-lib/src/verifier/stark_verify.rs

@@ -102,7 +102,7 @@ impl StarkVerify {
                 .unwrap();
 
             // Extension challenge weights
-            proof_stream.sample_scalars(Challenges::SAMPLE_COUNT);
+            let _challenges = proof_stream.sample_scalars(Challenges::SAMPLE_COUNT);
 
             // Extension-table Merkle root
             let _ext_mt_root = proof_stream
@@ -122,7 +122,7 @@ impl StarkVerify {
                 .unwrap();
 
             // Out-of-domain point current row
-            proof_stream.sample_scalars(1);
+            let _out_of_domain_point_curr_row = proof_stream.sample_scalars(1);
 
             // Five out-of-domain values
             proof_stream
@@ -694,6 +694,7 @@ impl BasicSnippet for StarkVerify {
                 call {get_challenges}
                 // _ *b_mr *p_iter padded_height *fri *challenges
 
+                // verify that the challenges are stored at the right place
                 {&verify_challenges_pointer}
                 // _ *b_mr *p_iter padded_height *fri
 
@@ -800,8 +801,6 @@ impl BasicSnippet for StarkVerify {
                 call {inner_product_quotient_summands}
                 // _ *b_mr *p_iter *oodpnts *fri *e_mr *odd_brow_nxt *quot_mr *ood_erow_nxt *ood_brow_curr *ood_erow_curr [sum_of_evaluated_out_of_domain_quotient_segments] [out_of_domain_quotient_value]
 
-                break
-
                 /* Verify quotient's segments */
                 {&assert_top_two_xfes_eq}
                 // _ *b_mr *p_iter *oodpnts *fri *e_mr *odd_brow_nxt *quot_mr *ood_erow_nxt *ood_brow_curr *ood_erow_curr