Sjmolyneux/two std normal notebook #116
Open
+577
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* LaTeX-ify introduction * Tidy graph construction section * LaTeX-ify solver sections * Clarify edges that are being added * Update examples/two_normal.ipynb * Update .pre-commit-config.yaml * Language for parameters has been decided --------- Co-authored-by: willGraham01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test that runs all notebooks in the examples folder to ensure that they run without error. This also included the addition of nbmake to the test dependencies.
We agreed not to use Jupytext for the time being, so I added an nbstripout hook to the pre-commit. This refuses to commit notebooks until all meta data has been stripped.
Of course 1. and 2. can be removed if we later decide to use Jupytext.
Added$\lVert \nabla \mathcal{L} \rVert_2^2$ . Notebook then demonstrates that the objective function can be easily changed and solves the problem using a custom objective function based up minimising KKT residuals.
examples/two_normal.ipynb. Notebook builds up an example graph using two normal distributions. Notebook then attempts to solve by running sgd onAdded some ruff ignores rules to examples folder. I think we probably don't care about these things missing in examples.
Closes #103.