quality-debt: tests/e2e/cypress/support/commands/login.js — PR #1282 review feedback (critical)

[superdav42]

Unactioned Review Feedback

Source PR: #1282
File: tests/e2e/cypress/support/commands/login.js
Reviewers: coderabbit
Findings: 2
Max severity: critical

---

CRITICAL: coderabbit (coderabbitai[bot])

File: tests/e2e/cypress/support/commands/login.js:49
⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Use tabs for indentation per coding guidelines.

The added lines use spaces for indentation, but the coding guidelines require tabs for all *.js files. As per coding guidelines, "indentation must be tabs".

🛠️ Proposed fix to convert spaces to tabs

-      cy.get("body").then(($body) => {
-        if ($body.find("`#rememberme`").length) {
-          cy.get("`#rememberme`").should("be.visible").and("not.be.checked").click();
-        }
-      });
+		cy.get("body").then(($body) => {
+			if ($body.find("`#rememberme`").length) {
+				cy.get("`#rememberme`").should("be.visible").and("not.be.checked").click();
+			}
+		});

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

		cy.get("body").then(($body) => {
			if ($body.find("`#rememberme`").length) {
				cy.get("`#rememberme`").should("be.visible").and("not.be.checked").click();
			}
		});

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/e2e/cypress/support/commands/login.js` around lines 45 - 49, The
indentation in the added block using cy.get("body").then(...) uses spaces;
update the indentation to use tabs consistent with the project's JS coding
guidelines. Locate the block containing cy.get("body").then(($body) => { ... })
and replace the leading spaces on each line inside that function (including the
if ($body.find("`#rememberme`")...) line and the cy.get("`#rememberme`")... line)
with tabs so the file uses tabs for indentation throughout.

View comment

---

CRITICAL: coderabbit (coderabbitai[bot])

File: tests/e2e/cypress/support/commands/login.js:59
⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Use tabs for indentation and tighten the pathname assertion.

Two concerns:

1. The line uses spaces for indentation, but the coding guidelines require tabs for all *.js files.
2. Using .include("/wp-admin") is overly permissive and would match unintended paths like /some-path/wp-admin or /not-wp-admin. To ensure the pathname starts with /wp-admin, use an anchored regex instead.

As per coding guidelines, "indentation must be tabs".

🛠️ Proposed fix

-      .and("include", "/wp-admin");
+		.and("match", /^\/wp-admin/);

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

		.and("match", /^\/wp-admin/);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/e2e/cypress/support/commands/login.js` at line 59, Update the assertion
that currently reads `.and("include", "/wp-admin")` to use an anchored regex
match so the pathname must start with `/wp-admin` (e.g., change to a
`.and("match", /^\/wp-admin/)` style check) and convert the indentation on that
line (and its surrounding lines if affected) from spaces to a single tab to
comply with the project JS indentation rule; look for the assertion chain
involving `.and("include", "/wp-admin")` in the login command and replace it
with the anchored regex match and tab-indented line.

View comment

---

---

Auto-generated by quality-feedback-helper.sh scan-merged. Review each finding and either fix the code or dismiss with a reason.

---

aidevops.sh v3.19.5 automated scan.

[superdav42]

Superseded. Pre-dispatch review-feedback validator found merged PR #1284 in the source PR #1282 merge window after 2026-05-27T01:12:59Z. The PR touches the cited file path(s) and matches the finding signal, so worker dispatch is skipped.

• Source PR: fix(e2e): stabilize Cypress login on custom login pages #1282
• Merged PR: fix(e2e): fall back to API login when login form is unavailable #1284
• Merged at: 2026-05-27T01:28:01Z
• Overlapping files: tests/e2e/cypress/support/commands/login.js
• Matched signal: admin check checked click diff

Closed automatically by the review-feedback supersession validator (t3569, GH#23101). If the finding recurs, a new review-feedback issue will be created by the next scan.

---

aidevops.sh v3.19.5 Overall, 1m since this issue was created.