rendervulkan: bump pScreenshotImages to 6 again (partially reverts 24bdce9) #1896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bdce9) This is to account for Steam settings that allow restricting the maximum game recording video height to 480px, 720px, 800px, 1080px, 1200px or 1440px. On a LCD Steam Deck with a vertical screen resolution of 800px, we need at least 3 textures (to capture at 480px, 720px or 800px). The previous default of 2 textures would trigger a crash when recording a video after cycling through all three possible maximum heights in the settings.
Collaborator
|
We should clear the array when the state changes probably. |
Author
Or when the But I'm not sure how to make the pipewire thread notify steamcompmgr of that event. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to account for Steam settings that allow restricting the maximum game recording video height to 480px, 720px, 800px, 1080px, 1200px or 1440px.
On a LCD Steam Deck with a vertical screen resolution of 800px, we need at least 3 textures (to capture at 480px, 720px or 800px). The previous default of 2 textures would trigger a crash when recording a video after cycling through all three possible maximum heights in the settings.