From 4dd330b4b6db27b8bf211aa7aa0b2e6a65a197ae Mon Sep 17 00:00:00 2001
From: ion098 <146852218+ion098@users.noreply.github.com>
Date: Wed, 27 Aug 2025 14:40:28 -0700
Subject: [PATCH 1/2] refactor: add noexcept and const specifiers to Result
 methods

---
 include/common/result.hpp | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/include/common/result.hpp b/include/common/result.hpp
index 5706bcb0..c6588fbf 100644
--- a/include/common/result.hpp
+++ b/include/common/result.hpp
@@ -33,6 +33,7 @@ class Result {
      * - T must have a default constructor
      */
     constexpr Result()
+        noexcept(std::is_nothrow_default_constructible_v<T>)
         requires std::default_initializable<T>
     = default;
 
@@ -47,6 +48,7 @@ class Result {
      * - T must be constructible with perfectly forwarded value argument
      */
     template<typename U>
+        // TODO: figure out correct noexcept specifier
         requires std::constructible_from<T, U&&>
     constexpr Result(U&& value)
         : value(std::forward<U>(value)) {}
@@ -60,6 +62,7 @@ class Result {
      * - T must be default initializable
      */
     constexpr Result(E error)
+        noexcept(std::is_nothrow_default_constructible_v<T>)
         requires std::default_initializable<T>
         : error(error) {}
 
@@ -75,6 +78,7 @@ class Result {
      * - T must be constructible with perfectly forwarded value argument
      */
     template<typename U>
+        // TODO: figure out correct noexcept specifier
         requires std::constructible_from<T, U&&>
     constexpr Result(E error, U&& value)
         : error(error),
@@ -85,7 +89,7 @@ class Result {
      *
      * @return T&
      */
-    constexpr operator T&() & {
+    constexpr operator T&() & noexcept {
         return value;
     }
 
@@ -94,7 +98,7 @@ class Result {
      *
      * @return const T&
      */
-    constexpr operator const T&() const& {
+    constexpr operator const T&() const& noexcept {
         return value;
     }
 
@@ -103,7 +107,7 @@ class Result {
      *
      * @return T&&
      */
-    constexpr operator T&&() && {
+    constexpr operator T&&() && noexcept {
         return std::move(value);
     }
 
@@ -117,6 +121,7 @@ class Result {
      * @return "normal" value
      */
     template<typename Self>
+    // TODO: figure out correct noexcept specifier
     constexpr auto get_value(this Self&& self) {
         return std::forward<Self>(self).value;
     }
@@ -127,7 +132,7 @@ class Result {
      * @return true an error is contained
      * @return false an error is not contained
      */
-    constexpr bool has_error() {
+    constexpr bool has_error() const noexcept {
         return error.has_value();
     }
 
@@ -139,7 +144,7 @@ class Result {
      * @return true error is contained
      * @return false error is not contained
      */
-    constexpr bool contains(E error) {
+    constexpr bool contains(E error) const noexcept(noexcept(std::declval<E>() == std::declval<E>())) {
         return this->error == error;
     }
 
@@ -147,4 +152,4 @@ class Result {
     bool operator==(const Result& other) = delete;
 };
 
-} // namespace zest
\ No newline at end of file
+} // namespace zest

From 44e9d989e1076268a5eb6491995848323960d703 Mon Sep 17 00:00:00 2001
From: ion098 <146852218+ion098@users.noreply.github.com>
Date: Fri, 29 Aug 2025 11:09:37 -0700
Subject: [PATCH 2/2] refactor: add more noexcept specifiers to Result class

---
 include/common/result.hpp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/include/common/result.hpp b/include/common/result.hpp
index c6588fbf..b4054fe6 100644
--- a/include/common/result.hpp
+++ b/include/common/result.hpp
@@ -48,7 +48,7 @@ class Result {
      * - T must be constructible with perfectly forwarded value argument
      */
     template<typename U>
-        // TODO: figure out correct noexcept specifier
+        noexcept(std::nothrow_constructible_from_v<T, U&&>)
         requires std::constructible_from<T, U&&>
     constexpr Result(U&& value)
         : value(std::forward<U>(value)) {}
@@ -78,7 +78,7 @@ class Result {
      * - T must be constructible with perfectly forwarded value argument
      */
     template<typename U>
-        // TODO: figure out correct noexcept specifier
+        noexcept(std::nothrow_constructible_from_v<T, U&&>)
         requires std::constructible_from<T, U&&>
     constexpr Result(E error, U&& value)
         : error(error),
@@ -121,8 +121,7 @@ class Result {
      * @return "normal" value
      */
     template<typename Self>
-    // TODO: figure out correct noexcept specifier
-    constexpr auto get_value(this Self&& self) {
+    constexpr auto get_value(this Self&& self) noexcept(noexcept(std::forward<Self>(self).value)) {
         return std::forward<Self>(self).value;
     }