MdeModulePkg/BrotliCustomDecompressLib: Correct BrotliDecompress

DestSize should have been received and passed as a pointer in order to
successfully pass the output value.

The existence of this error was spotted by XCODE5 toolchain, which gave:
BrotliDecompress.c:85:18: error: parameter 'DestSize' set but not used

As discussed in tianocore/edk2#11729, since the
method is in fact internal and only called in one place, and since the
DestSize return value is in fact unused, instead of fixing the parameter
and method call we instead remove the parameter, also marking the method
STATIC and renaming it to ...Internal.

Signed-off-by: Mike Beaton <[email protected]>

Author: mikebeaton

MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliDecompress.c

@@ -68,7 +68,6 @@ BrFree (
   @param  Source      The source buffer containing the compressed data.
   @param  SourceSize  The size of source buffer.
   @param  Destination The destination buffer to store the decompressed data.
-  @param  DestSize    The destination buffer size.
   @param  BuffInfo    The pointer to the BROTLI_BUFF instance.
 
   @retval EFI_SUCCESS Decompression completed successfully, and
@@ -77,12 +76,12 @@ BrFree (
                       The source buffer specified by Source is corrupted
                       (not in a valid compressed format).
 **/
+STATIC
 EFI_STATUS
-BrotliDecompress (
+BrotliDecompressInternal (
   IN CONST VOID  *Source,
   IN UINTN       SourceSize,
   IN OUT VOID    *Destination,
-  IN OUT UINTN   *DestSize,
   IN VOID        *BuffInfo
   )
 {
@@ -157,8 +156,6 @@ BrotliDecompress (
     CopyMem (Temp, Output, (size_t)(NextOut - Output));
   }
 
-  *DestSize = TotalOut;
-
   BrFree (BuffInfo, Input);
   BrFree (BuffInfo, Output);
   BrotliDecoderDestroyInstance (BroState);
@@ -276,7 +273,6 @@ BrotliUefiDecompress (
   IN OUT VOID    *Scratch
   )
 {
-  UINTN        DestSize = 0;
   EFI_STATUS   Status;
   BROTLI_BUFF  BroBuff;
   UINT64       GetSize;
@@ -288,11 +284,10 @@ BrotliUefiDecompress (
   BroBuff.Buff     = Scratch;
   BroBuff.BuffSize = (UINTN)GetSize;
 
-  Status = BrotliDecompress (
+  Status = BrotliDecompressInternal (
              (VOID *)((UINT8 *)Source + BROTLI_SCRATCH_MAX),
              SourceSize - BROTLI_SCRATCH_MAX,
              Destination,
-             &DestSize,
              (VOID *)(&BroBuff)
              );