fix: sale price comparison #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical bug in the
formatPricefunction. The oldformatPricelogic compared prices as strings instead of numbers, which broke sale-price detection. Example: "9" is considered greater than "100" in a string comparison, even though 9 is obviously less than 100. The fix switches the comparisons to numeric by wrapping the values in parseFloat(), so sale prices resolve correctly again.Changes
Core Implementation
parseFloat(final) < parseFloat(regular)instead of direct string comparisonformatPricefunction to enable unit testingTest Coverage
Example
Before (Bug)
After (Fixed)