Skip to content

Commit 27d061a

Browse files
VincentMolinieVincent Molinié
andauthored
fix: prevent You attempted to update _tracking on Tag issue on Ember-data 4.5+ (#482)
* fix: prevent You attempted to update _tracking on Tag issue ibn Ember-data 4.6 * fix: support correctly ember data below 4.5 * ci: include the new scenario into the CI --------- Co-authored-by: Vincent Molinié <[email protected]>
1 parent 2417348 commit 27d061a

File tree

3 files changed

+34
-7
lines changed

3 files changed

+34
-7
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ jobs:
178178
fail-fast: true
179179
matrix:
180180
ember-try-scenario:
181-
[ember-lts-3.28, ember-lts-4.4, ember-classic]
181+
[ember-lts-3.28, ember-lts-4.4, ember-4.6, ember-4.8, ember-classic]
182182
allow-failure: [false]
183183
include:
184184
- ember-try-scenario: ember-release

addon/record-data.js

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -967,12 +967,21 @@ export default class FragmentRecordData extends RecordData {
967967
}
968968

969969
notifyStateChange(key) {
970-
this.storeWrapper.notifyStateChange(
971-
this.modelName,
972-
this.id,
973-
this.clientId,
974-
key
975-
);
970+
if (key && gte('ember-data', '4.5.0')) {
971+
this.storeWrapper.notifyPropertyChange(
972+
this.modelName,
973+
this.id,
974+
this.clientId,
975+
key
976+
);
977+
} else {
978+
this.storeWrapper.notifyStateChange(
979+
this.modelName,
980+
this.id,
981+
this.clientId,
982+
key
983+
);
984+
}
976985
}
977986

978987
/*

tests/dummy/config/ember-try.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,24 @@ module.exports = async function () {
2525
},
2626
},
2727
},
28+
{
29+
name: 'ember-4.6',
30+
npm: {
31+
devDependencies: {
32+
'ember-source': '~4.6.0',
33+
'ember-data': '~4.6.0',
34+
},
35+
},
36+
},
37+
{
38+
name: 'ember-4.8',
39+
npm: {
40+
devDependencies: {
41+
'ember-source': '~4.8.0',
42+
'ember-data': '~4.8.0',
43+
},
44+
},
45+
},
2846
{
2947
name: 'ember-release',
3048
npm: {

0 commit comments

Comments
 (0)