AG-16323 Fix options graph cache to be isolated per chart instance

Author: lsjroberts

packages/ag-charts-community/src/api/agCharts.ts

@@ -218,6 +218,7 @@ class AgChartsInternal {
             optionsMetadata,
             deltaOptions,
             stripSymbols,
+            chart?.id,
             apiStartTime
         );
 

packages/ag-charts-community/src/module/optionsGraph.ts

@@ -43,7 +43,7 @@ import {
 const debug = Debug.create('opts', 'options-graph');
 
 export const createOptionsGraph = simpleMemorize(createOptionsGraphFn);
-export function createOptionsGraphFn(theme: ChartTheme, options: PlainObject) {
+export function createOptionsGraphFn(theme: ChartTheme, options: PlainObject, cachePrefix?: string) {
     return debug.group(
         'OptionsGraph.constructor()',
         () =>
@@ -53,7 +53,8 @@ export function createOptionsGraphFn(theme: ChartTheme, options: PlainObject) {
                 theme.params,
                 theme.palette,
                 theme.overrides,
-                theme.getTemplateParameters()
+                theme.getTemplateParameters(),
+                cachePrefix
             )
     );
 }
@@ -134,7 +135,8 @@ export class OptionsGraph extends AdjacencyListGraph<unknown, string> implements
         params: PlainObject | undefined = undefined,
         public readonly palette: PlainObject = {},
         private readonly overrides: PlainObject | undefined = undefined,
-        private readonly internalParams: Map<unknown, unknown> = new Map()
+        private readonly internalParams: Map<unknown, unknown> = new Map(),
+        private readonly cachePrefix: string = 'shared'
     ) {
         super(PATH_EDGE, OPERATION_EDGE, new Set([USER_PARTIAL_OPTIONS_EDGE, USER_OPTIONS_EDGE]));
 
@@ -516,12 +518,12 @@ export class OptionsGraph extends AdjacencyListGraph<unknown, string> implements
     }
 
     getCachedValue(path: string[], key: string): unknown {
-        const cacheKey = [...path, key].join('.');
+        const cacheKey = [this.cachePrefix, ...path, key].join('.');
         return OptionsGraph.valueCache.get(cacheKey);
     }
 
     setCachedValue(path: string[], key: string, value: unknown): void {
-        const cacheKey = [...path, key].join('.');
+        const cacheKey = [this.cachePrefix, ...path, key].join('.');
         OptionsGraph.valueCache.set(cacheKey, value);
     }
 

packages/ag-charts-community/src/module/optionsModule.ts

@@ -165,6 +165,7 @@ export class ChartOptions<T extends AgChartOptions = AgChartOptions> {
         metadata: ChartInternalOptionMetadata,
         deltaOptions?: DeepPartial<T> | null,
         stripSymbols = false,
+        cachePrefix?: string,
         apiStartTime?: number
     ) {
         this.optionMetadata = metadata ?? {};
@@ -219,7 +220,7 @@ export class ChartOptions<T extends AgChartOptions = AgChartOptions> {
         } else {
             ChartOptions.perfDebug(`ChartOptions.slowSetup()`);
             ({ activeTheme, processedOptions, themeParameters, annotationThemes, googleFonts, optionsGraph } =
-                this.slowSetup(processedOverrides, deltaOptions, stripSymbols));
+                this.slowSetup(processedOverrides, deltaOptions, stripSymbols, cachePrefix));
         }
 
         this.activeTheme = activeTheme;
@@ -276,7 +277,12 @@ export class ChartOptions<T extends AgChartOptions = AgChartOptions> {
         }
     }
 
-    private slowSetup(processedOverrides: Partial<T>, deltaOptions?: DeepPartial<T> | null, stripSymbols = false) {
+    private slowSetup(
+        processedOverrides: Partial<T>,
+        deltaOptions?: DeepPartial<T> | null,
+        stripSymbols = false,
+        cachePrefix?: string
+    ) {
         let options = deepClone(this.userOptions, ChartOptions.OPTIONS_CLONE_OPTS_FAST) as T & { type?: string };
 
         if (deltaOptions) {
@@ -354,7 +360,7 @@ export class ChartOptions<T extends AgChartOptions = AgChartOptions> {
         this.processSeriesOptions(options);
         this.processAxesOptions(options, chartType);
 
-        const optionsGraph = createOptionsGraph(activeTheme, options);
+        const optionsGraph = createOptionsGraph(activeTheme, options, cachePrefix);
         const resolvedOptions = optionsGraph.resolve() as any;
         const themeParameters = optionsGraph.resolveParams();
         const annotationThemes = optionsGraph.resolveAnnotationThemes();