fix: Stop replays if the main projection flow stops #1381
Closed
+92
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
commented
Nov 25, 2025
| private val streamDone = source.run() | ||
| private val streamDone = source | ||
| .via(projectionState.killSwitch.flow) | ||
| .run() |
Contributor
Author
There was a problem hiding this comment.
An alternative I tried here is to give it a bit of time to possibly write in flights completed offsets etc:
source
.viaMat(KillSwitches.single)(Keep.right)
.mapMaterializedValue { killSwitch =>
import system.executionContext
projectionState.abort.future.onComplete(_ =>
akka.pattern.after(1.second)(Future {
killSwitch.abort(AbortProjectionException)
}))
}
.run()
But I don't think it is worth it, better to just shut down as fast as possible.
Contributor
Author
There was a problem hiding this comment.
Not quite sure why it is needed in this scenario, it should work anyway, but the test failed until I added this faster downstream killswitch. I'll investigate that a bit more.
Contributor
Author
There was a problem hiding this comment.
Aah, ofc, it's no surprise at all, killswitch going downstream is just completion, which travels in order with the events. So if backpressuring the completion will get stuck.
Contributor
Author
|
If we instead submaterialize replays, we won't need this. |
Contributor
Author
|
No longer relevant because of #1385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(possibly) references https://github.com/lightbend/akka-runtime/issues/4536