Do not compile on VS 2017

I have this errors:

<function-style-cast>: cannot convert from 'initializer list' to ak_toolkit::static_str::string<39,ak_toolkit::static_str::select_conctenated_array_tag<ak_toolkit::static_str::char_array,ak_toolkit::static_str::char_array>::type>

constexpr function ak_toolkit::static_str::operator + cannot result in a constant expression

template parameter TR cannot be used because it follows a template parameter pack and cannot be deduced from the function parameters of ak_toolkit::static_str::string<N,ak_toolkit::static_str::array_suffix>::string

link to godbolt

[akrzemi1]

Hi. The link shows only some code using boost::optional, which does compile.

[pixelblender]

Same issue here. VS2017 latest update.

static_string.hpp(202): error C3547: template parameter 'TR' cannot be used because it follows a template parameter pack and cannot be deduced from the function parameters of 'ak_toolkit::static_str::string<N,ak_toolkit::static_str::char_array>::string'

[akrzemi1]

Thanks for the report. The link does not a appear to work for me. It looks like a generic link to Godbolt, but not to particular example. Or maybe you could paste the program code here?

[pixelblender]

Hi,

I was trying to follow your example but can't compile.

#include "static_string.hpp"
namespace sstr = ak_toolkit::static_str;

int main()
{
  constexpr auto fpath = sstr::literal("path/fname");
  constexpr auto fname = sstr::suffix(fpath, 5);
  constexpr auto full_fname = fname + ".txt";
}

[olm-dev]

Hi! I found this lib very cool and useful before I noticed it can't compile following the standard. Compiling with VS2017/2019 (std=C++17) shows errors reported by pixelblender, which are legitimate. To do it right, you just have to displace 'unresolvable' template types before any variadic template parameters declaration, that is, for sstr::string case:

REPLACE:
template <int M, int... Il, int... Ir, typename TL, typename TR>
constexpr explicit string(...)
BY
template <int M, typename TL, typename TR, int... Il, int... Ir>
constexpr explicit string(...)

And change any explicit template usage according to that order!
THX

[danra]

Same issue with VS2019

[akrzemi1]

I have just implemented the suggested patch. Does this fix MSVC build?

[olm-dev]

Hi! It solves one issue only, msvc complains about not being capable of deducing template parameters on static_string ctors, if I recall this issue well. I'll send you the exact compiling issue when I have hands on it, which should be soon! I think, this time, msvc might not be right, but I'll tell you then. Still, to circumvent this last issue, it is feasible to rewrite ctors with less genericity (too bad), not using the template selector (between literals and char_arrays). Still, it would be great to keep it because it's really less verbose! Le mer. 17 juin 2020 à 09:20, Andrzej Krzemieński <notifications@github.com> a écrit :

…

I have just implemented the suggested patch. Does this fix MSVC build? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOFXWIKWGUXV2IKUGIKEK5TRXBVELANCNFSM4FGYH4IQ> .