fixed a multiple execution bug to avoid redundant execution of analysis passes

Author: alexander-pick

shannon_indirect_xref.py

@@ -4,10 +4,12 @@
 # A lean IDA Pro loader for fancy baseband research
 # Alexander Pick 2024-2025
 
-import os
 import idc
 import ida_segment
 import ida_ua
+
+import os
+
 import shannon_generic
 
 max_ops = 6

shannon_pal_reconstructor.py

@@ -141,6 +141,8 @@ def find_pal_msg_funcs():
                                   ida_name.SN_NOCHECK | ida_name.SN_FORCE)
 
         find_pal_msg_init(pal_MsgSendTo_addr)
+    
+    return
 
 
 # try to find pal_MsgInit() and a few others along
@@ -202,6 +204,8 @@ def find_pal_msg_init(pal_MsgSendTo_addr):
                 break
 
             func_cnt += 1
+            
+    return
 
 # try to find Task SCheduler, Task Inits and pal_Init()
 def find_pal_init():

shannon_postprocess.py

@@ -170,9 +170,14 @@ def auto_empty_finally(self):
         global post_processed
 
         # avoid this to be triggered twice
-        if(post_processed): 
+        if(post_processed is True): 
             return
-        post_processed = True
+        else:
+            post_processed = True
+        
+        # avoid multiple execution paths if a segment get split due to scatter etc.
+        boot_processed_once = False
+        main_processed_once = False
 
         # start calculating runtime
         start_time = time.process_time()
@@ -196,40 +201,48 @@ def auto_empty_finally(self):
 
             # add some names
             if (seg_name == "BOOT_file"):
+    
+                if(boot_processed_once is False):
+                    
+                    boot_processed_once = True
 
-                shannon_generic.get_ref_set_name(seg_start, "start")
+                    shannon_generic.get_ref_set_name(seg_start, "start")
 
             if (seg_name == "MAIN_file"):
+                
+                if(main_processed_once is False):
+                    
+                    main_processed_once = True
 
-                shannon_generic.get_ref_set_name(seg_start, "reset_v")
+                    shannon_generic.get_ref_set_name(seg_start, "reset_v")
 
-                shannon_generic.get_ref_set_name(seg_start + 4, "undef_inst_v")
+                    shannon_generic.get_ref_set_name(seg_start + 4, "undef_inst_v")
 
-                shannon_generic.get_ref_set_name(seg_start + 8, "soft_int_v")
+                    shannon_generic.get_ref_set_name(seg_start + 8, "soft_int_v")
 
-                shannon_generic.get_ref_set_name(seg_start + 12, "prefetch_abort_v")
+                    shannon_generic.get_ref_set_name(seg_start + 12, "prefetch_abort_v")
 
-                shannon_generic.get_ref_set_name(seg_start + 16, "data_abort_v")
+                    shannon_generic.get_ref_set_name(seg_start + 16, "data_abort_v")
 
-                shannon_generic.get_ref_set_name(seg_start + 20, "reserved_v")
+                    shannon_generic.get_ref_set_name(seg_start + 20, "reserved_v")
 
-                shannon_generic.get_ref_set_name(seg_start + 24, "irq_v")
+                    shannon_generic.get_ref_set_name(seg_start + 24, "irq_v")
 
-                shannon_generic.get_ref_set_name(seg_start + 28, "fiq_v")
+                    shannon_generic.get_ref_set_name(seg_start + 28, "fiq_v")
 
-                self.memory_ranges()
+                    self.memory_ranges()
 
-                # it is very important to do this in the correct order
-                # especially for new modems or the result will be left
-                # in a weird state
+                    # it is very important to do this in the correct order
+                    # especially for new modems or the result will be left
+                    # in a weird state
 
-                shannon_mpu.find_hw_init()
-                shannon_mpu.scan_for_mrc()
+                    shannon_mpu.find_hw_init()
+                    shannon_mpu.scan_for_mrc()
 
-                shannon_scatterload.find_scatter()
+                    shannon_scatterload.find_scatter()
 
-                shannon_pal_reconstructor.find_pal_msg_funcs()
-                shannon_pal_reconstructor.find_pal_init()
+                    shannon_pal_reconstructor.find_pal_msg_funcs()
+                    shannon_pal_reconstructor.find_pal_init()
 
         find_rvct()