Skip to content

Conversation

@wenchiangh
Copy link

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

  1. in formily-react, render.ts will try to create a div element when load module, this action may throw a error in some non web browser. But in render function, env.portalDOM just work with env.createPortal, so I try to create env.portalDOM lazy when env.createPortal not undefined (or loaded). I also add a environment test before create a div element.
  2. also, template not support in non web browser environment, and globalThisPolyfill?.navigator?.product === 'ReactNative' just support RN, then I try to test template element support in current environment directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant