Merge pull request quarkusio#50895 from gsmet/compose-dev-services-ports

Be more defensive with container.getPorts()

Author: geoand

extensions/devservices/common/src/main/java/io/quarkus/devservices/common/ContainerLocator.java

@@ -64,6 +64,10 @@ private Stream<Container> lookup(String expectedLabelValue) {
     }
 
     private Optional<ContainerPort> getMappedPort(Container container, int port) {
+        if (container.getPorts() == null) {
+            return Optional.empty();
+        }
+
         return Arrays.stream(container.getPorts())
                 .filter(containerPort -> hasMatchingPort(containerPort, port))
                 .findAny();
@@ -99,6 +103,10 @@ public Optional<String> locateContainer(String serviceName, boolean shared, Laun
         if (shared && launchMode == LaunchMode.DEVELOPMENT) {
             return lookup(serviceName).findAny()
                     .map(container -> {
+                        if (container.getPorts() == null) {
+                            return container.getId();
+                        }
+
                         Arrays.stream(container.getPorts())
                                 .filter(cp -> Objects.nonNull(cp.getPublicPort()) && Objects.nonNull(cp.getPrivatePort()))
                                 .forEach(cp -> {

extensions/devservices/deployment/src/main/java/io/quarkus/devservices/deployment/DevServicesProcessor.java

@@ -349,6 +349,10 @@ private static Map<String, String[]> getNetworks(Container container) {
     }
 
     private ContainerInfo.ContainerPort[] getExposedPorts(Container container) {
+        if (container.getPorts() == null) {
+            return new ContainerInfo.ContainerPort[0];
+        }
+
         return Arrays.stream(container.getPorts())
                 .map(c -> new ContainerInfo.ContainerPort(c.getIp(), c.getPrivatePort(), c.getPublicPort(), c.getType()))
                 .toArray(ContainerInfo.ContainerPort[]::new);

extensions/devservices/deployment/src/main/java/io/quarkus/devservices/deployment/compose/ComposeServiceWaitStrategyTarget.java

@@ -32,11 +32,11 @@ public class ComposeServiceWaitStrategyTarget implements WaitStrategyTarget, Sup
     public ComposeServiceWaitStrategyTarget(DockerClient dockerClient, Container container) {
         this.dockerClient = dockerClient;
         this.container = container;
-        this.exposedPorts = Arrays.stream(container.getPorts())
+        this.exposedPorts = container.getPorts() != null ? Arrays.stream(container.getPorts())
                 .filter(port -> port.getPublicPort() != null)
                 .map(ContainerPort::getPrivatePort)
                 .filter(Objects::nonNull)
-                .toList();
+                .toList() : List.of();
     }
 
     @Override