[Amber] Fix: Feature: Add browser push notification support#489
Closed
github-actions[bot] wants to merge 1 commit intomainfrom
Closed
[Amber] Fix: Feature: Add browser push notification support#489github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
Implements browser push notifications to keep users informed of session events even when not actively viewing the application. Backend changes: - Add push subscription management endpoints (CRUD operations) - Add VAPID public key endpoint for Push API - Store subscriptions in namespace-scoped ConfigMaps - Implement RBAC checks for subscription access - Add comprehensive error handling and logging Frontend changes: - Add Push API service for subscription management - Add push notification manager for browser integration - Add React Query hooks for subscription state - Implement service worker for background notifications - Add permission request flow Features: - Notification preferences (session start/complete/error, run finish/error) - Service worker for background delivery - Automatic permission handling - Browser compatibility checks - Test notification functionality Documentation: - Comprehensive guide in docs/push-notifications.md - Architecture overview and data flow - API endpoint documentation - Configuration guide (VAPID keys) - Browser compatibility matrix - Troubleshooting guide Security: - User-scoped K8s clients with RBAC enforcement - Per-user, per-project subscription isolation - No sensitive data in notification payloads - VAPID key management via environment variables Future integration points: - SSE event stream (websocket/agui.go) - Operator phase transitions (operator/internal/handlers/sessions.go) - Web Push protocol implementation (requires push library) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
github-actions
bot
added
amber-generated
16 tasks
Contributor
|
leaving it open because i think we want this but not ready to pick it back up |
Contributor
|
Moving this to draft. needs more research |
Contributor
|
Closing — this Amber auto-generated PR is failing CI (frontend build + lint errors) and has been stale for 2+ months. We'll revisit browser push notification support properly in the near future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Fix by Amber Agent
This PR addresses issue #488 using the Amber background agent.
Changes Summary
Pre-merge Checklist
Reviewer Notes
This PR was automatically generated. Please review:
🤖 Generated with Amber Background Agent
Closes #488