Skip to content

feat: add CODEOWNERS file for maintainer approval requirements#809

Merged
Gkrumbach07 merged 1 commit intoambient-code:mainfrom
ralphbean:add-codeowners-file
Mar 5, 2026
Merged

feat: add CODEOWNERS file for maintainer approval requirements#809
Gkrumbach07 merged 1 commit intoambient-code:mainfrom
ralphbean:add-codeowners-file

Conversation

@ralphbean
Copy link
Contributor

Summary

Add CODEOWNERS file to establish code review requirements for the Ambient Code Platform repository.

Changes

  • Creates .github/CODEOWNERS with @ambient-maintainers as required approvers for all files
  • Includes documentation and examples for future bot-based approval workflows
  • Documents the pattern where automated approvals could be permitted for most files while restricting critical files (CLAUDE.md, CRDs, operator code) to human maintainer oversight

Repository Settings Required

⚠️ This file will only take effect after enabling branch protection:

  1. Go to Settings > Branches > Branch protection rules for main
  2. Enable "Require review from Code Owners"
  3. (Optional but recommended) Enable "Require approvals" and set minimum number of approvals

Without this setting enabled, the CODEOWNERS file will be informational only and won't block PR merges.

Documentation

See GitHub CODEOWNERS documentation for more details on the file format and capabilities.

Add CODEOWNERS file to establish code review requirements for the
Ambient Code Platform. All files currently require approval from
@ambient-maintainers.

The file includes documentation and examples for future bot-based
approval workflows, where automated approvals could be permitted for
most files while restricting critical files (CLAUDE.md, CRDs, operator
code) to human maintainer oversight.

Note: Requires enabling "Require review from Code Owners" in repository
branch protection settings to take effect.

Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Ralph Bean <rbean@redhat.com>
@ambient-code ambient-code bot added this to the Merge Queue milestone Mar 5, 2026
Copy link
Contributor

@ktdreyer ktdreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Gkrumbach07 Gkrumbach07 merged commit e2b6af4 into ambient-code:main Mar 5, 2026
5 checks passed
@ralphbean
Copy link
Contributor Author

📈 thanks @Gkrumbach07 !

@ambient-code ambient-code bot removed this from the Merge Queue milestone Mar 5, 2026
@ktdreyer
Copy link
Contributor

ktdreyer commented Mar 9, 2026

Mergify rules will build on this, #858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants