Skip to content

Commit b353b64

Browse files
erwinmombayerwinmombay
committed
Merge branch 'master' into release
2 parents 154b0f7 + 5566fb8 commit b353b64

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+1746
-449
lines changed

‎ads/doubleclick.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ export function doubleclick(global, data) {
3030
const slot = googletag.defineSlot(data.slot, dimensions, 'c')
3131
.addService(googletag.pubads());
3232
googletag.pubads().enableSingleRequest();
33+
googletag.pubads().markAsAmp();
3334
googletag.pubads().set('page_url', context.canonicalUrl);
3435
googletag.enableServices();
3536

‎build-system/tasks/presubmit-checks.js‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,15 @@ var forbiddenTerms = {
4848
message: requiresReviewPrivacy,
4949
whitelist: [
5050
'src/cid.js',
51+
'src/service/cid-impl.js',
5152
'test/functional/test-cid.js',
5253
],
5354
},
5455
'cookie\\W': {
5556
message: requiresReviewPrivacy,
5657
whitelist: [
5758
'src/cookies.js',
58-
'src/cid.js',
59+
'src/service/cid-impl.js',
5960
'test/functional/test-cid.js',
6061
'test/functional/test-cookies.js',
6162
'test/functional/test-experiments.js',
@@ -64,7 +65,7 @@ var forbiddenTerms = {
6465
'getCookie\\W': {
6566
message: requiresReviewPrivacy,
6667
whitelist: [
67-
'src/cid.js',
68+
'src/service/cid-impl.js',
6869
'src/cookies.js',
6970
'src/experiments.js',
7071
'test/functional/test-cookies.js',
@@ -85,7 +86,7 @@ var forbiddenTerms = {
8586
message: requiresReviewPrivacy,
8687
whitelist: [
8788
'test/_init_tests.js',
88-
'src/cid.js',
89+
'src/service/cid-impl.js',
8990
'test/functional/test-cid.js',
9091
],
9192
},

‎builtins/amp-pixel.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ A simple URL to send a GET request to when the tracking pixel is loaded.
3131
#### Substitutions
3232

3333
The `amp-pixel` allows all standard URL variable substitutions.
34-
See (Substitutions Guide)[../spec/amp-var-substitutions.md] for more info.
34+
See [Substitutions Guide](../spec/amp-var-substitutions.md) for more info.
3535

3636
For instance:
3737
```html

‎css/amp.css‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -321,3 +321,16 @@ amp-ad iframe {
321321
amp-instagram {
322322
padding: 48px 8px !important;
323323
}
324+
325+
326+
/**
327+
* Analytics tags should never be visible. keep them hidden.
328+
*/
329+
amp-analytics {
330+
position: absolute !important;
331+
top: 0 !important;
332+
width: 1px !important;
333+
height: 1px !important;
334+
overflow: hidden !important;
335+
visibility: hidden;
336+
}

‎examples/analytics.amp.html‎

Lines changed: 79 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
1+
<!doctype html>
2+
<html ⚡>
3+
<head>
4+
<meta charset="utf-8">
5+
<title>AMP #0</title>
6+
<link rel="canonical" href="amps.html" >
7+
<meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1">
8+
<link href='https://fonts.googleapis.com/css?family=Questrial' rel='stylesheet' type='text/css'>
9+
<style amp-custom>
10+
amp-img {
11+
max-width: 80%;
12+
max-height: 80%;
13+
width: 100%;
14+
}
15+
</style>
16+
<script async custom-element="amp-analytics" src="https://cdn.ampproject.org/v0/amp-analytics-0.1.js"></script>
17+
<style>body {opacity: 0}</style><noscript><style>body {opacity: 1}</style></noscript>
18+
<script async src="https://cdn.ampproject.org/v0.js"></script>
19+
</head>
20+
<body>
21+
22+
<article>
23+
<amp-analytics id="analytics1">
24+
{
25+
"host": "my-analytics.com",
26+
"requests": {
27+
"default": "/log?domain=DOMAIN&amp;path=PATH"
28+
},
29+
"triggers": [{
30+
"on": "visible",
31+
"request": "default"
32+
}]
33+
}
34+
</amp-analytics>
35+
<amp-analytics type="googleanalytics" id="analytics2">
36+
{
37+
"vars": {
38+
"account": "UA-123456-1",
39+
"anonymize_ip": true
40+
},
41+
"triggers": [{
42+
"on": "visible",
43+
"request": "pageview"
44+
}]
45+
}
46+
</amp-analytics>
47+
<div class="logo"></div>
48+
49+
<h1 id="top">AMP #0</h1>
50+
<p>
51+
<amp-fit-text width="300" height="200" layout="responsive" class="box1">
52+
Lorem ipsum dolor sit amet, has nisl nihil convenire et, vim at aeque inermis reprehendunt.
53+
</amp-fit-text>
54+
</p>
55+
<p>
56+
<div class="box1">
57+
Lorem ipsum dolor sit amet, has nisl nihil convenire et, vim at aeque inermis reprehendunt.
58+
</div>
59+
</p>
60+
<p>
61+
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Suspendisse semper aliquet turpis ac fringilla. Cras dolor nisi, malesuada eu semper non, faucibus sed nisl. Quisque urna velit, accumsan non ante ac, fermentum dignissim justo. Etiam libero massa, commodo a dignissim eu, fringilla eu ante. Nam neque diam, tincidunt in rhoncus a, luctus ac eros. Integer tellus mauris, convallis quis mauris et, tincidunt venenatis lorem. Maecenas vulputate pulvinar quam. Phasellus nec felis ultrices, faucibus dui eu, sodales arcu. Nullam pellentesque erat at lorem volutpat vehicula. Phasellus id lectus risus. Proin consectetur dapibus nulla eget viverra. Donec a scelerisque metus. Morbi vitae diam tempor, facilisis risus id, cursus erat.
62+
63+
Maecenas tellus dolor, euismod eget porta eu, pretium in diam. Nulla fermentum iaculis leo et ornare. Mauris euismod, risus vitae auctor lacinia, massa elit eleifend neque, sit amet tincidunt nisi diam quis quam. Donec id vestibulum leo, tempor lobortis erat. Nunc eget porta eros. Proin mi leo, iaculis vitae dui at, euismod auctor ante. Integer ut mi nisl. Morbi ut ipsum vel quam fermentum maximus. Morbi aliquet massa quis justo malesuada, sit amet tempus est tempor. Nulla tincidunt orci odio, sed porta nisl fermentum quis. Etiam rhoncus vel eros ut mollis. Nulla vitae risus vel diam porta rutrum vitae a mi. Curabitur id bibendum mi. Morbi sagittis id dui eu suscipit. Pellentesque porttitor placerat nisi non volutpat.
64+
65+
Curabitur mattis libero a venenatis porta. Integer ac aliquam nulla. Nunc non orci sit amet metus consectetur fermentum. Suspendisse et velit sit amet nulla rhoncus semper. Vivamus et dolor tempus, ultricies metus at, lacinia nisi. Nunc justo dui, efficitur ut orci eget, vehicula feugiat est. Suspendisse non urna congue, feugiat est nec, tempus nisi. In convallis vitae lectus eu finibus. Vestibulum ullamcorper id turpis id pulvinar. Nulla facilisi. Aenean purus odio, imperdiet sed nisl ut, luctus ullamcorper leo. Aenean sit amet pharetra nunc. Integer maximus diam vitae tortor lobortis, sed facilisis ante vehicula. Mauris rutrum pharetra pretium. Praesent laoreet faucibus odio, quis fringilla libero convallis quis.
66+
67+
Suspendisse viverra augue nec elementum ornare. Nulla vel dui at leo pharetra dapibus non nec risus. Vestibulum hendrerit leo felis, vel accumsan mi molestie vel. Aenean nisi quam, iaculis eu erat euismod, tristique euismod magna. Maecenas sem ante, consectetur et magna ut, pulvinar euismod arcu. Nullam eget mollis dolor, ac tristique ex. Nulla at elit pretium elit aliquam facilisis nec ut sapien. Duis et sem dapibus, pharetra risus sit amet, vulputate libero. Fusce commodo tellus sit amet arcu egestas varius. Integer nunc nisl, maximus tincidunt magna sed, aliquam molestie lectus. Suspendisse mollis ac diam et ornare. Nam ut suscipit odio. Integer arcu tellus, sagittis in tempus gravida, elementum sit amet nulla. Sed non nisl odio.
68+
69+
Nunc a ipsum nisi. Proin sodales vestibulum nisl, non viverra ipsum efficitur eu. Sed vitae mi congue, vestibulum diam nec, semper odio. Nulla nec luctus mauris. Pellentesque ornare nulla at mi tempor bibendum. Cras quis viverra nunc. Nulla condimentum neque a dictum ullamcorper.
70+
71+
</p>
72+
<p>
73+
<amp-img id="img1" src="https://lh3.googleusercontent.com/pSECrJ82R7-AqeBCOEPGPM9iG9OEIQ_QXcbubWIOdkY=w400-h300-no-n" width=800 height=600></amp-img>
74+
<amp-img src="https://lh3.googleusercontent.com/5rcQ32ml8E5ONp9f9-Rf78IofLb9QjS5_0mqsY1zEFc=w400-h300-no-n" width=400 height=300 layout=responsive></amp-img>
75+
<amp-img src="https://lh3.googleusercontent.com/Z4gtm5Bkxyv21Z2PtbTf95Clb9AE4VTR6olbBKYrenM=w400-h300-no-n" width=400 height=300></amp-img>
76+
</p>
77+
</article>
78+
</body>
79+
</html>

0 commit comments

Comments
 (0)