Skip to content

Commit 42ae679

Browse files
committed
Log at info when an alert skips a disabled or filtered webhook
1 parent 52d87fa commit 42ae679

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

‎plugins/event-bus/webhook/src/main/java/org/apache/cloudstack/mom/webhook/WebhookServiceImpl.java‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -297,12 +297,13 @@ protected List<Runnable> getDirectDeliveryJobs(List<Long> webhookIds, long accou
297297
event.setResourceAccountUuid(account != null ? account.getUuid() : null);
298298
for (Long webhookId : webhookIds) {
299299
WebhookVO webhook = webhookDao.findById(webhookId);
300+
// Info level, as the caller picked these webhooks and would otherwise not know why nothing arrived.
300301
if (webhook == null || !Webhook.State.Enabled.equals(webhook.getState())) {
301-
logger.debug("Skipping delivering {} to webhook ID: {} as it is missing or disabled", event, webhookId);
302+
logger.info("Skipping delivering {} to webhook ID: {} as it is missing or disabled", eventType, webhookId);
302303
continue;
303304
}
304305
if (!isEventMatchingFilters(event, webhookFiltersCache.get(webhook.getId()))) {
305-
logger.debug("Skipping delivering {} to {} as it doesn't match filters", event, webhook);
306+
logger.info("Skipping delivering {} to {} as it doesn't match the webhook filters", eventType, webhook);
306307
continue;
307308
}
308309
WebhookDeliveryThread.WebhookDeliveryContext<WebhookDeliveryThread.WebhookDeliveryResult> context =

0 commit comments

Comments
 (0)