Fix: NPE thrown on VMware to KVM migration tasks listing for removed VMs (#11892)

nvazquez · web-flow · commit 4b74a99a57ca · 2025-10-23T10:40:17.000+05:30
diff --git a/server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java b/server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java
@@ -209,7 +209,10 @@ private ImportVMTaskResponse createImportVMTaskResponse(ImportVMTaskVO task) {
         }
         if (task.getVmId() != null) {
             UserVmVO userVm = userVmDao.findById(task.getVmId());
-            response.setVirtualMachineId(userVm.getUuid());
+            if (userVm != null) {
+                // Migrated VM could have been removed from CloudStack after the migration
+                response.setVirtualMachineId(userVm.getUuid());
+            }
         }
         response.setCreated(task.getCreated());
         response.setLastUpdated(task.getUpdated());

Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,10 @@ private ImportVMTaskResponse createImportVMTaskResponse(ImportVMTaskVO task) {`
`209`	`209`	`}`
`210`	`210`	`if (task.getVmId() != null) {`
`211`	`211`	`UserVmVO userVm = userVmDao.findById(task.getVmId());`
`212`		`- response.setVirtualMachineId(userVm.getUuid());`
	`212`	`+ if (userVm != null) {`
	`213`	`+ // Migrated VM could have been removed from CloudStack after the migration`
	`214`	`+ response.setVirtualMachineId(userVm.getUuid());`
	`215`	`+ }`
`213`	`216`	`}`
`214`	`217`	`response.setCreated(task.getCreated());`
`215`	`218`	`response.setLastUpdated(task.getUpdated());`