Skip to content

Commit 81b2c38

Browse files
Merge branch '4.22'
2 parents dbda673 + ac8c200 commit 81b2c38

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

api/src/main/java/org/apache/cloudstack/api/command/admin/storage/UpdateStoragePoolCmd.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,8 @@ public void execute() {
153153
if (ObjectUtils.anyNotNull(name, capacityIops, capacityBytes, url, isTagARule, tags) ||
154154
MapUtils.isNotEmpty(details)) {
155155
result = _storageService.updateStoragePool(this);
156+
} else {
157+
result = _storageService.getStoragePool(getId());
156158
}
157159

158160
if (enabled != null) {

test/integration/smoke/test_direct_download.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,10 @@ def getCurrentStoragePoolTags(self, poolId):
251251
self.apiclient,
252252
id=poolId
253253
)
254-
return local_pool[0].tags
254+
if local_pool[0].tags:
255+
return local_pool[0].tags
256+
else:
257+
return ""
255258

256259
def updateStoragePoolTags(self, poolId, tags):
257260
StoragePool.update(

ui/src/views/compute/DeployVM.vue

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -928,6 +928,7 @@
928928
import { ref, reactive, toRaw, nextTick, h } from 'vue'
929929
import { Button, message } from 'ant-design-vue'
930930
import { getAPI, postAPI } from '@/api'
931+
import { isAdmin } from '@/role'
931932
import _ from 'lodash'
932933
import { mixin, mixinDevice } from '@/utils/mixin.js'
933934
import store from '@/store'
@@ -1232,6 +1233,7 @@ export default {
12321233
return _.map(this.affinityGroups, 'id')
12331234
},
12341235
params () {
1236+
const listAll = isAdmin()
12351237
return {
12361238
serviceOfferings: {
12371239
list: 'listServiceOfferings',
@@ -1279,25 +1281,31 @@ export default {
12791281
domainid: this.owner.domainid,
12801282
projectid: this.owner.projectid,
12811283
keyword: undefined,
1282-
listall: false
1284+
listall: listAll
12831285
}
12841286
},
12851287
sshKeyPairs: {
12861288
list: 'listSSHKeyPairs',
12871289
options: {
12881290
page: 1,
12891291
pageSize: 10,
1292+
account: this.owner.account,
1293+
domainid: this.owner.domainid,
1294+
projectid: this.owner.projectid,
12901295
keyword: undefined,
1291-
listall: false
1296+
listall: listAll
12921297
}
12931298
},
12941299
userDatas: {
12951300
list: 'listUserData',
12961301
options: {
12971302
page: 1,
12981303
pageSize: 10,
1304+
account: this.owner.account,
1305+
domainid: this.owner.domainid,
1306+
projectid: this.owner.projectid,
12991307
keyword: undefined,
1300-
listall: false
1308+
listall: listAll
13011309
}
13021310
},
13031311
networks: {

0 commit comments

Comments
 (0)