Skip to content

[hotfix] Tracks the number of pending manual compactions. #27105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −0
Open

[hotfix] Tracks the number of pending manual compactions. #27105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...nd-rocksdb/src/main/java/org/apache/flink/state/rocksdb/sstmerge/CompactionScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ public void maybeScan() {
}

for (CompactionTask target : targets) {
tracker.addManualCompaction();
ioExecutor.execute(
() ->
tracker.runWithTracking(
Expand Down
4 changes: 4 additions & 0 deletions ...kend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/sstmerge/CompactionTracker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ private synchronized void runIfNoManualCompactions(Runnable runnable) {
}
}

public synchronized void addManualCompaction() {
Copy link
Contributor

@davidradl davidradl Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the method name does not seem correct. haveManualCompactions refers to runningManualCompactions and pendingManualCompactions. I suggest scheduleManualCompaction.

Copy link
Contributor

@davidradl davidradl Oct 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add some unit tests for this class.
I am curious about the method

private synchronized void cancel() {
        pendingManualCompactions--;
    }

If the cancel can be called while it is running then the pending counter could go negative - as we have already decremented the pending counter when we incremented the running one.

pendingManualCompactions++;
}

public synchronized boolean haveManualCompactions() {
return runningManualCompactions > 0 || pendingManualCompactions > 0;
}
Expand Down