commitstatus to enum

Author: jx2lee

pyiceberg/catalog/bigquery_metastore.py

@@ -17,6 +17,7 @@
 from __future__ import annotations
 
 import json
+from enum import Enum
 from typing import TYPE_CHECKING, Any
 
 from google.api_core.exceptions import NotFound
@@ -69,6 +70,12 @@
 HIVE_FILE_OUTPUT_FORMAT = "org.apache.iceberg.mr.hive.HiveIcebergOutputFormat"
 
 
+class BigqueryCommitStatus(str, Enum):
+    SUCCESS = "SUCCESS"
+    FAILURE = "FAILURE"
+    UNKNOWN = "UNKNOWN"
+
+
 class BigQueryMetastoreCatalog(MetastoreCatalog):
     def __init__(self, name: str, **properties: str):
         super().__init__(name, **properties)
@@ -307,9 +314,9 @@ def commit_table(
         finally:
             if commit_error:
                 commit_status = self._check_bigquery_commit_status(table_ref, updated_staged_table.metadata_location)
-                if commit_status == "SUCCESS":
+                if commit_status == BigqueryCommitStatus.SUCCESS:
                     commit_error = None
-                elif commit_status == "UNKNOWN":
+                elif commit_status == BigqueryCommitStatus.UNKNOWN:
                     raise CommitStateUnknownException(
                         f"Commit state unknown for table {dataset_name}.{table_name}"
                     ) from commit_error
@@ -539,10 +546,10 @@ def _check_bigquery_commit_status(self, table_ref: TableReference, new_metadata_
             )
             current_metadata_location = parameters.get(METADATA_LOCATION_PROP)
             if current_metadata_location == new_metadata_location:
-                return "SUCCESS"
+                return BigqueryCommitStatus.SUCCESS
 
             if not current_metadata_location:
-                return "FAILURE"
+                return BigqueryCommitStatus.FAILURE
 
             io = self._load_file_io(location=current_metadata_location)
             current_metadata = FromInputFile.table_metadata(io.new_input(current_metadata_location))
@@ -552,11 +559,11 @@ def _check_bigquery_commit_status(self, table_ref: TableReference, new_metadata_
             if previous_metadata_location:
                 previous_metadata_locations.add(previous_metadata_location)
 
-            return "SUCCESS" if new_metadata_location in previous_metadata_locations else "FAILURE"
+            return BigqueryCommitStatus.SUCCESS if new_metadata_location in previous_metadata_locations else "FAILURE"
         except NotFound:
-            return "FAILURE"
+            return BigqueryCommitStatus.FAILURE
         except Exception:
-            return "UNKNOWN"
+            return BigqueryCommitStatus.UNKNOWN
 
     def _default_storage_location(self, location: str | None, dataset_ref: DatasetReference) -> str | None:
         if location: