Skip to content

Commit 2025e27

Browse files
committed
Address review feedback: use warehouse.as_uri() and clarify docstring
1 parent 1fd76c7 commit 2025e27

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎pyiceberg/table/__init__.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ def _build_partition_predicate(
433433
return Or(*per_record_exprs) if len(per_record_exprs) > 1 else per_record_exprs[0]
434434

435435
def _get_evolved_partition_fields(self, current_spec: PartitionSpec) -> set[str]:
436-
"""Find partition fields in the current spec that were absent in any historical partitioned spec."""
436+
"""Find partition fields in the current spec that were absent in at least one historical partitioned spec."""
437437
historical_specs = [
438438
spec
439439
for spec in self.table_metadata.specs().values()

‎tests/table/test_init.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2064,7 +2064,7 @@ def test_dynamic_partition_overwrite_with_partition_spec_evolution(warehouse: Pa
20642064

20652065
from pyiceberg.catalog.sql import SqlCatalog
20662066

2067-
catalog = SqlCatalog(name="test", uri=f"sqlite:///{warehouse.as_posix()}/test_dpo_evolve.db", warehouse=f"file://{warehouse}")
2067+
catalog = SqlCatalog(name="test", uri=f"sqlite:///{warehouse.as_posix()}/test_dpo_evolve.db", warehouse=warehouse.as_uri())
20682068
catalog.create_namespace("default")
20692069
schema = Schema(
20702070
NestedField(1, "category", StringType(), required=False),

0 commit comments

Comments
 (0)