Address review: validate format-version property strictly

Reject non-integer format-version values in set_properties with a
clear error instead of truncating floats or failing with a confusing
cast error, and verify in the integration test that the upgraded
metadata persists and reloads from the catalog.

Author: moomindani

pyiceberg/table/__init__.py

@@ -359,6 +359,8 @@ def set_properties(self, properties: Properties = EMPTY_DICT, **kwargs: Any) ->
             raise ValueError("Cannot pass both properties and kwargs")
         updates = dict(properties or kwargs)
         if (new_format_version := updates.pop(TableProperties.FORMAT_VERSION, None)) is not None:
+            if isinstance(new_format_version, bool) or not str(new_format_version).isdigit():
+                raise ValueError(f"Invalid format-version: {new_format_version}")
             self.upgrade_table_version(format_version=cast(TableVersion, int(new_format_version)))
         if updates:
             return self._apply((SetPropertiesUpdate(updates=updates),))

tests/integration/test_reads.py

@@ -977,6 +977,11 @@ def test_upgrade_table_version(catalog: Catalog) -> None:
     assert table_test_table_version.format_version == 3
     assert table_test_table_version.metadata.next_row_id == 0
 
+    # the upgraded metadata must persist and reload from the catalog
+    reloaded = catalog.load_table("default.test_table_version")
+    assert reloaded.format_version == 3
+    assert reloaded.metadata.next_row_id == 0
+
     with pytest.raises(ValueError) as e:
         with table_test_table_version.transaction() as transaction:
             transaction.upgrade_table_version(format_version=4)  # type: ignore[arg-type]

tests/table/test_init.py

@@ -2065,3 +2065,10 @@ def _spy(*args: Any, **kwargs: Any) -> FileIO:
 
     assert seen_locations, "expected at least one load_file_io call"
     assert all(loc is not None for loc in seen_locations), f"load_file_io called without a location: {seen_locations}"
+
+
+def test_set_properties_invalid_format_version_rejected(table_v2: Table) -> None:
+    transaction = table_v2.transaction()
+    for invalid in ("3.0", "three", "-1"):
+        with pytest.raises(ValueError, match="Invalid format-version"):
+            transaction.set_properties({"format-version": invalid})