Skip to content

Commit ffd73bf

Browse files
committed
ignore failed sql due to ansi and exception gap, add more sql tests
Signed-off-by: Yuan <[email protected]>
1 parent 5b9d9f5 commit ffd73bf

File tree

1 file changed

+48
-10
lines changed

1 file changed

+48
-10
lines changed

gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxSQLQueryTestSettings.scala

Lines changed: 48 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,12 @@ object VeloxSQLQueryTestSettings extends SQLQueryTestSettings {
2929
// Put relative path to "/path/to/spark/sql/core/src/test/resources/sql-tests/inputs" in this list
3030
// Gluten currently only supports `SET spark.sql.legacy.timeParserPolicy=LEGACY`
3131
// Queries in `date.sql` and `timestamp.sql` are tested in `datetime-legacy.sql`.
32+
// There is a limitation in Spark-4.0 on ANSI gap and exception message gap.
33+
// we disabled these sql tests temporarily.
34+
// limit.sql, postgreSQL/limit.sql, subquery/in-subquery/in-limit.sql,
35+
// subquery/in-subquery/in-null-semantics.sql
36+
// try_arithmetic.sql, try_element_at.sql, typeCoercion/native/stringCastAndExpressions.sql,
37+
// window.sql
3238
val SUPPORTED_SQL_QUERY_LIST: Set[String] = Set(
3339
"ansi/conditional-functions.sql",
3440
"ansi/decimalArithmeticOperations.sql",
@@ -83,7 +89,7 @@ object VeloxSQLQueryTestSettings extends SQLQueryTestSettings {
8389
"keywords.sql",
8490
"like-all.sql",
8591
"like-any.sql",
86-
"limit.sql",
92+
// "limit.sql",
8793
"literals.sql",
8894
"map.sql",
8995
"mask-functions.sql",
@@ -128,7 +134,7 @@ object VeloxSQLQueryTestSettings extends SQLQueryTestSettings {
128134
"subquery/in-subquery/in-group-by.sql",
129135
"subquery/in-subquery/in-having.sql",
130136
"subquery/in-subquery/in-joins.sql",
131-
"subquery/in-subquery/in-limit.sql",
137+
// "subquery/in-subquery/in-limit.sql",
132138
"subquery/in-subquery/in-multiple-columns.sql",
133139
"subquery/in-subquery/in-nullability.sql",
134140
"subquery/in-subquery/in-order-by.sql",
@@ -167,7 +173,7 @@ object VeloxSQLQueryTestSettings extends SQLQueryTestSettings {
167173
"postgreSQL/int8.sql",
168174
"postgreSQL/interval.sql",
169175
"postgreSQL/join.sql",
170-
"postgreSQL/limit.sql",
176+
// "postgreSQL/limit.sql",
171177
"postgreSQL/numeric.sql",
172178
"postgreSQL/select.sql",
173179
"postgreSQL/select_distinct.sql",
@@ -214,7 +220,34 @@ object VeloxSQLQueryTestSettings extends SQLQueryTestSettings {
214220
"udf/postgreSQL/udf-select_having.sql - Scala UDF",
215221
"union.sql",
216222
"unpivot.sql",
217-
"using-join.sql"
223+
"using-join.sql",
224+
// newly added in Spark-4.0
225+
"variant/named-function-arguments.sql",
226+
"timestampNTZ/datetime-special-ansi.sql",
227+
"timestampNTZ/datetime-special.sql",
228+
"timestampNTZ/timestamp-ansi.sql",
229+
"timestampNTZ/timestamp.sql",
230+
"nonansi/array.sql",
231+
"nonansi/cast.sql",
232+
"nonansi/conditional-functions.sql",
233+
"nonansi/date.sql",
234+
"nonansi/datetime-parsing-invalid.sql",
235+
"nonansi/datetime-special.sql",
236+
"nonansi/decimalArithmeticOperations.sql",
237+
"nonansi/double-quoted-identifiers.sql",
238+
"nonansi/higher-order-functions.sql",
239+
"nonansi/interval.sql",
240+
"nonansi/keywords.sql",
241+
"nonansi/literals.sql",
242+
"nonansi/map.sql",
243+
"nonansi/math.sql",
244+
"nonansi/parse-schema-string.sql",
245+
"nonansi/string-functions.sql",
246+
"nonansi/timestamp.sql",
247+
"nonansi/try_aggregates.sql",
248+
"nonansi/try_arithmetic.sql",
249+
"nonansi/try_datetime_functions.sql",
250+
"nonansi/try_element_at.sql"
218251
)
219252

220253
val OVERWRITE_SQL_QUERY_LIST: Set[String] = Set(
@@ -259,11 +292,13 @@ object VeloxSQLQueryTestSettings extends SQLQueryTestSettings {
259292
// Removed some result mismatch cases.
260293
"string-functions.sql",
261294
// Removed some result mismatch cases.
262-
"try_arithmetic.sql",
295+
// TODO: Disable due to schema & ANSI gap
296+
// "try_arithmetic.sql",
263297
// Removed some result mismatch cases.
264298
"try_cast.sql",
265299
// Removed SQLs that can only pass with `set spark.sql.legacy.timeParserPolicy=LEGACY;`
266-
"typeCoercion/native/stringCastAndExpressions.sql",
300+
// TODO: Disable due to schema & ANSI gap
301+
// "typeCoercion/native/stringCastAndExpressions.sql",
267302
// Enable ConstantFolding rule for some queries.
268303
"percentiles.sql",
269304
// Enable ConstantFolding rule for some queries, otherwise Spark will throw an exception.
@@ -273,14 +308,17 @@ object VeloxSQLQueryTestSettings extends SQLQueryTestSettings {
273308
// Enable ConstantFolding rule for some queries, otherwise Spark will throw an exception.
274309
"postgreSQL/window_part4.sql",
275310
// Enable NullPropagation rule for some queries that rely on the rule.
276-
"subquery/in-subquery/in-null-semantics.sql",
311+
// TODO: Disable due to schema & ANSI gap
312+
// "subquery/in-subquery/in-null-semantics.sql",
277313
// Removed some result mismatch cases.
278314
"try_datetime_functions.sql",
279315
// Overwrite exception message.
280-
"try_element_at.sql",
316+
// TODO: Disable due to schema & ANSI gap
317+
// "try_element_at.sql",
281318
// Overwrite exception message.
282-
"url-functions.sql",
319+
"url-functions.sql"
283320
// Removed failed query. Adjust the output order for some queries.
284-
"window.sql"
321+
// TODO: Disable due to schema & ANSI gap
322+
// "window.sql"
285323
)
286324
}

0 commit comments

Comments
 (0)