[MCHECKSTYLE-405] The checkstyle plugin should report the number of all violations

[jira-importer]

Guillaume Nodet opened MCHECKSTYLE-405 and commented

When there is an error, the build looks like:

[INFO] There is 1 error reported by Checkstyle 8.41.1 with config/maven_checks.xml ruleset.
[ERROR] src/main/java/org/apache/maven/execution/BuildResumptionDataRepository.java:[54,30] (whitespace) ParenPad: '(' is not followed by whitespace.
 

and when this error is fixed, the build then looks like:

[INFO] You have 0 Checkstyle violations.

The problem is that checkstyle never caches the results for files with violations, even at info or warning level. This cause the files to be always processed, without the user really being aware of any problem.

The number of violations at info or warning level should also be printed. In addition, if there are errors, the output should be logged at WARN level.

---

1 votes, 2 watchers

[jira-importer]

Guillaume Nodet commented

The main problem is actually caused by the violationSeverity configuration parameter which silently ignores some violations. Any file containing a violation can not be cached by checkstyle, so the result is that the user does not see any violation, but files are not cached.

See apache/maven@ec1b78b

[jira-importer]

Jeff Thomas commented

Came here looking for this exact issue :)

I also find the reported number of violations '0' when "{}failOnViolation=false{}" misleading. 

I am a wee bit OCD so I want the count even if I don't want to break the build on violations. :P