arch/arm,riscv/rp23xx: Silence "LOAD segment with RWX permissions" linker warnings #16930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nker warnings Setting the "--no-warn-rwx-segments" linker option Port of apache#16886 Signed-off-by: Serg Podtynnyi <[email protected]>
github-actions
bot
added
Arch: arm
| include armv8-m/Make.defs | ||
|
|
||
| CFLAGS += -Wno-array-bounds | ||
| LDFLAGS += --no-warn-rwx-segments |
Contributor
There was a problem hiding this comment.
why not move to Toolchain.defs
Contributor
Author
There was a problem hiding this comment.
here? nuttx/arch/arm/src/armv8-m/Toolchain.defs and nuttx/arch/risc-v/src/common/Toolchain.defs
Contributor
There was a problem hiding this comment.
nuttx/arch/arm/src/common/Toolchain.defs is better. Actually, --no-warn-rwx-segments was added in this file with some condition guard, we can remove the check directly.
| HEAD_ASRC = rp23xx_head.S | ||
|
|
||
| CFLAGS += -Wno-array-bounds | ||
| LDFLAGS += --no-warn-rwx-segments |
Contributor
|
Any updates @shtirlic ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Setting the "--no-warn-rwx-segments" linker option
Port of #16886
Impact
No more rwx warnings while linking