-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Hardware Checksum Offload Support for NuttX Network Stack #16940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bc64464 to
7520a52
Compare
Implementation of main hardware verification and uninstallation functions Signed-off-by: daichuan <[email protected]>
Fix compilation errors and add build files Signed-off-by: daichuan <[email protected]>
7520a52 to
d17e875
Compare
When supporting hardware checksum offloading, the network protocol stack does not perform TCP/UDP pseudo-header checksum calculation. Skip TCP/UDP pseudo header checksum calculation in network protocol stack Signed-off-by: daichuan <[email protected]>
d17e875 to
f60daab
Compare
| logic. | ||
|
|
||
| config NETDEV_CHECKSUM | ||
| bool "netdev hardware checksum" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| bool "netdev hardware checksum" | |
| bool "Enable support to netdev checksum in Hardware" |
|
|
||
| config NETDEV_CHECKSUM | ||
| bool "netdev hardware checksum" | ||
| default n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is something that depends on chip supporting it, shouldn't it have a "depends on ARCH_HAVE_NETDEV_CHKSUM_HW" ?
@xiaoxiang781216 @raiden00pl please comment
|
@13627105546 since it is a new feature, please include basic Documentation to it. The documentation should be included at https://nuttx.apache.org/docs/latest/components/net/netdev.html as a new section |
acassis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add Documentation
How did you quantify this? Which applications did you run, on what hardware, and how did you verify that they worked correctly? |
@13627105546 the Testing should have the list of boards and applications you tested: i.e. tested on esp32-devkitc running iperf, thttpd, telnet, etc... |
Note: Please adhere to Contributing Guidelines.
Summary
This PR introduces hardware checksum offload support to the NuttX network protocol stack, enabling network devices to perform checksum calculations in hardware rather than software.
Key Changes:
Impact
Build Impact:
API Impact:
Runtime Impact:
Testing
All existing network applications function correctly