fix(navbar): extract popup offset into shared constant

Author: gabotorresruiz

superset-frontend/src/features/home/Menu.tsx

@@ -33,6 +33,7 @@ import {
   MenuData,
 } from 'src/types/bootstrapTypes';
 import RightMenu from './RightMenu';
+import { NAVBAR_MENU_POPUP_OFFSET } from './commonMenuData';
 
 interface MenuProps {
   data: MenuData;
@@ -277,7 +278,7 @@ export function Menu({
       key: label,
       label,
       icon: <Icons.DownOutlined iconSize="xs" />,
-      popupOffset: [0, -8],
+      popupOffset: NAVBAR_MENU_POPUP_OFFSET,
       children: childItems,
     };
   };

superset-frontend/src/features/home/RightMenu.tsx

@@ -53,6 +53,7 @@ import {
   GlobalMenuDataOptions,
   RightMenuProps,
 } from './types';
+import { NAVBAR_MENU_POPUP_OFFSET } from './commonMenuData';
 
 const extensionsRegistry = getExtensionsRegistry();
 
@@ -379,7 +380,7 @@ const RightMenu = ({
               label: menu.label,
               icon: menu.icon,
               children: childItems,
-              popupOffset: [0, -8],
+              popupOffset: NAVBAR_MENU_POPUP_OFFSET,
             });
           } else if (menu.url) {
             if (
@@ -560,7 +561,7 @@ const RightMenu = ({
         className: 'submenu-with-caret',
         icon: <Icons.DownOutlined iconSize="xs" />,
         children: buildNewDropdownItems(),
-        popupOffset: [0, -8],
+        popupOffset: NAVBAR_MENU_POPUP_OFFSET,
       });
     }
 
@@ -578,7 +579,7 @@ const RightMenu = ({
       icon: <Icons.DownOutlined iconSize="xs" />,
       children: buildSettingsMenuItems(),
       className: 'submenu-with-caret',
-      popupOffset: [0, -8],
+      popupOffset: NAVBAR_MENU_POPUP_OFFSET,
     });
 
     return items;

superset-frontend/src/features/home/commonMenuData.ts

@@ -18,6 +18,11 @@
  */
 import { t } from '@superset-ui/core';
 
+/**
+ * Shared popup offset configuration for navbar menu dropdowns.
+ */
+export const NAVBAR_MENU_POPUP_OFFSET: [number, number] = [0, -8];
+
 export const commonMenuData = {
   name: t('SQL'),
   tabs: [

superset-frontend/src/hooks/useThemeMenuItems.tsx

@@ -21,6 +21,7 @@ import { Icons, Tooltip } from '@superset-ui/core/components';
 import type { MenuItem } from '@superset-ui/core/components/Menu';
 import { t } from '@superset-ui/core';
 import { ThemeMode, ThemeAlgorithm } from '@apache-superset/core/ui';
+import { NAVBAR_MENU_POPUP_OFFSET } from 'src/features/home/commonMenuData';
 
 export interface ThemeSubMenuOption {
   key: ThemeMode;
@@ -138,6 +139,6 @@ export const useThemeMenuItems = ({
     icon: <Icons.DownOutlined iconSize="xs" />,
     className: 'submenu-with-caret',
     children,
-    popupOffset: [0, -8],
+    popupOffset: NAVBAR_MENU_POPUP_OFFSET,
   };
 };