Skip to content

Commit 6785c8f

Browse files
authored
[CI] Enable username checks in PR title and body (#18432)
Enable username checks in PR title and body
1 parent 4b555a9 commit 6785c8f

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

ci/scripts/jenkins/check_pr.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -69,19 +69,17 @@ def trailing_period(s: str):
6969
title_checks = [
7070
Check(check=non_empty, error_fn=lambda d: "PR must have a title but title was empty"),
7171
Check(check=trailing_period, error_fn=lambda d: "PR must not end in a tailing '.'"),
72-
# TODO(driazati): enable this check once https://github.com/apache/tvm/issues/12637 is done
73-
# Check(
74-
# check=usernames,
75-
# error_fn=lambda d: f"PR title must not tag anyone but found these usernames: {d}",
76-
# ),
72+
Check(
73+
check=usernames,
74+
error_fn=lambda d: f"PR title must not tag anyone but found these usernames: {d}",
75+
),
7776
]
7877
body_checks = [
7978
Check(check=non_empty, error_fn=lambda d: "PR must have a body but body was empty"),
80-
# TODO(driazati): enable this check once https://github.com/apache/tvm/issues/12637 is done
81-
# Check(
82-
# check=usernames,
83-
# error_fn=lambda d: f"PR body must not tag anyone but found these usernames: {d}",
84-
# ),
79+
Check(
80+
check=usernames,
81+
error_fn=lambda d: f"PR body must not tag anyone but found these usernames: {d}",
82+
),
8583
]
8684

8785

0 commit comments

Comments
 (0)