Percent encode semicolons when using GET (#840)

AnthonyMDev · gh-action-runner · commit 1b27d2047fdc · 2025-11-05T23:13:13.000Z
diff --git a/apollo-ios/Sources/Apollo/GraphQLGETTransformer.swift b/apollo-ios/Sources/Apollo/GraphQLGETTransformer.swift
@@ -49,8 +49,9 @@ public struct GraphQLGETTransformer {
       components.queryItems = queryItems
     }
 
+    let allowedCharacters = CharacterSet(charactersIn: "+;").inverted
     components.percentEncodedQuery =
-      components.percentEncodedQuery?.replacingOccurrences(of: "+", with: "%2B")
+      components.percentEncodedQuery?.addingPercentEncoding(withAllowedCharacters: allowedCharacters)
 
     return components.url
   }

Original file line number	Diff line number	Diff line change
`@@ -49,8 +49,9 @@ public struct GraphQLGETTransformer {`
`49`	`49`	`components.queryItems = queryItems`
`50`	`50`	`}`
`51`	`51`
	`52`	`+ let allowedCharacters = CharacterSet(charactersIn: "+;").inverted`
`52`	`53`	`components.percentEncodedQuery =`
`53`		`- components.percentEncodedQuery?.replacingOccurrences(of: "+", with: "%2B")`
	`54`	`+ components.percentEncodedQuery?.addingPercentEncoding(withAllowedCharacters: allowedCharacters)`
`54`	`55`
`55`	`56`	`return components.url`
`56`	`57`	`}`