Percent encode semicolons when using GET (apollographql/apollo-ios-dev#812)

nevil · gh-action-runner · commit 1025aa9bb923 · 2025-10-16T18:46:05.000Z
diff --git a/Sources/Apollo/URLQueryParameterTransformer.swift b/Sources/Apollo/URLQueryParameterTransformer.swift
@@ -48,8 +48,9 @@ public struct URLQueryParameterTransformer {
       components.queryItems = queryItems
     }
 
+    let allowedCharacters = CharacterSet(charactersIn: "+;").inverted
     components.percentEncodedQuery =
-      components.percentEncodedQuery?.replacingOccurrences(of: "+", with: "%2B")
+      components.percentEncodedQuery?.addingPercentEncoding(withAllowedCharacters: allowedCharacters)
 
     return components.url
   }

Original file line number	Diff line number	Diff line change
`@@ -48,8 +48,9 @@ public struct URLQueryParameterTransformer {`
`48`	`48`	`components.queryItems = queryItems`
`49`	`49`	`}`
`50`	`50`
	`51`	`+ let allowedCharacters = CharacterSet(charactersIn: "+;").inverted`
`51`	`52`	`components.percentEncodedQuery =`
`52`		`- components.percentEncodedQuery?.replacingOccurrences(of: "+", with: "%2B")`
	`53`	`+ components.percentEncodedQuery?.addingPercentEncoding(withAllowedCharacters: allowedCharacters)`
`53`	`54`
`54`	`55`	`return components.url`
`55`	`56`	`}`