Builders #21
Builders #21
Conversation
This comes redundant with Cells internals, but this is due to what may be a flaw in current Apotomo's design, which bypass Cells workflow (#render_cell_for) and hook directly into AbstractController::Rendering. Using Cells' #create_cell_for proved cumbersome due to the different naming conventions, so here's the most direct patch I found atm.
This comes redundant with Cells internals, but this is due to what may be a flaw in current Apotomo's design, which bypass Cells workflow (#render_cell_for) and hook directly into AbstractController::Rendering. Using Cells' #create_cell_for proved cumbersome due to the different naming conventions, so here's the most direct patch I found atm.
|
@apotonick @chikamichi Don't you what there were on IRC? :-D It's seems to be down now... And what does this code do? Thanks for attention. |
|
Honestly I didn't understand your question :) |
|
@chikamichi You wrote: 'Saw that on IRC'. But I can't open IRC channel. |
|
This code adds cells' builder functionality (https://github.com/apotonick/cells/blob/master/README.rdoc#builders) to apotomo. I had a conceptual issue with that and forgot to work on it. |
|
Honestly I don't remember much about this too. It's been 2 years. |
|
So 👍 to merge :) Are tests and docs necessary? |
|
There was a problem from a conceptional point of view, I can't remember it On Tue, Feb 12, 2013 at 2:27 PM, Kurakin Alexander <[email protected]
|
|
@apotonick haven't you remember now? :-) |
|
Hi @apotonick ! I think we should close this PR ;) ⌛ |
3 participants
Saw that on IRC. Builders support for Apotomo, with a larger pending refactoring I guess.