Support building pkl rules from external workspace #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KushalP
reviewed
Jul 16, 2025
Contributor
KushalP
left a comment
KushalP
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
Let's remove the comment in the script, as the commit message will contain this context on merge.
More importantly, please can you add a test reproduction of this to tests/integration_tests/example_workspaces so we can catch any regressions.
Comment on lines
+69
to
+71
| # The ruleset currently assumes the {label}/work directory exists due to creation of the symlinks | ||
| # However when running a `pkl_eval` frome external to the workspsace, the symlinks exist external | ||
| # to the {label}/work directory and it is not created, causing the command below to have issues. |
Contributor
There was a problem hiding this comment.
Suggested change
| # The ruleset currently assumes the {label}/work directory exists due to creation of the symlinks | |
| # However when running a `pkl_eval` frome external to the workspsace, the symlinks exist external | |
| # to the {label}/work directory and it is not created, causing the command below to have issues. |
sitaktif
added a commit
to sitaktif/rules_pkl
that referenced
this pull request
Sep 22, 2025
* feat(pkl project package): Create pkl project package rule (apple#86) * add pkl project package rule * add copyright notice to tortoise.pkl, tidy up defs.bzl * add pkl package to defs.bzl * gitignore formatting * minor formatting of pklproject and deps.json files * update .bazelrc and .bazelignore for integration tests * update repo rule to use pkl executable * update pkl executable failure message in repo rule * update os name and architecture in pkl project repo rule * update os name and architecture in pkl project repo rule * update os name and architecture in pkl project repo rule * partial address of PR comments * continue addressing PR comments - remove run shell, add doc for pkl package * run docs updater * address remaining pr comments * add docstring to pkl_project repo rule make package optional: Co-authored-by: Steve Barrau <[email protected]> remove package from simple/PklProject integration test correct formatting remove refs to workspace in pkl_project add pkl project package rule gitignore formatting partial address of PR comments correct defs.bzl update simple example test pklproject small formatting change * begin addressing PR comments * fix(pkl_project): include src files in packaged pkl project * feat(pkl_project): add strip_prefix attribute * fix(pkl_project): include src files in packaged pkl project * feat(pkl_project): add strip_prefix attribute * add test to pkl package with srcs included * update docs * add another test as per PR comments * fix path ref * Apply suggestions from code review * fix CI failure * update docs --------- Co-authored-by: Romain Chossart <[email protected]> Co-authored-by: Philip K.F. Hölzenspies <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a bug that blocked us from building pkls from outside the workspace they are defined in.
There was a slight bug where the pkl-cli binary expects the
/workdirectory to be created by one of the symlinks but in the case of a pkl that is defined completely externally nothing lives under the current workspace so none of the symlinks ever create the work directory and then the pkl-cli binary looks for the import in the wrong place