Improve error handling

Signed-off-by: Tamal Saha <[email protected]>

Author: tamalsaha

kubernetes/go.mod

@@ -6,7 +6,6 @@ toolchain go1.24.1
 
 require (
 	github.com/gogo/protobuf v1.3.2
-	github.com/pkg/errors v0.9.1
 	go.bytebuilders.dev/license-proxyserver v0.0.20
 	go.bytebuilders.dev/license-verifier v0.14.7
 	k8s.io/api v0.30.2
@@ -49,6 +48,7 @@ require (
 	github.com/modern-go/reflect2 v1.0.2 // indirect
 	github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
 	github.com/opencontainers/go-digest v1.0.0 // indirect
+	github.com/pkg/errors v0.9.1 // indirect
 	github.com/rancher/norman v0.0.0-20240708202514-a0127673d1b9 // indirect
 	github.com/rancher/rancher/pkg/client v0.0.0-20240710123941-93e332156bbe // indirect
 	github.com/rancher/wrangler/v3 v3.0.0 // indirect

kubernetes/lib.go

@@ -31,7 +31,7 @@ import (
 	"go.bytebuilders.dev/license-verifier/apis/licenses/v1alpha1"
 	"go.bytebuilders.dev/license-verifier/info"
 
-	"github.com/pkg/errors"
+	"errors"
 	proxyserver "go.bytebuilders.dev/license-proxyserver/apis/proxyserver/v1alpha1"
 	proxyclient "go.bytebuilders.dev/license-proxyserver/client/clientset/versioned"
 	verifier "go.bytebuilders.dev/license-verifier"
@@ -109,15 +109,18 @@ func (le *LicenseEnforcer) getLicense() ([]byte, error) {
 		}
 		pc, err := proxyclient.NewForConfig(le.config)
 		if err != nil {
-			return nil, errors.Wrap(err, "failed create client for license-proxyserver")
+			return nil, fmt.Errorf("failed to instantiate proxy client, err: %w", err)
 		}
 		resp, err := pc.ProxyserverV1alpha1().LicenseRequests().Create(context.TODO(), &req, metav1.CreateOptions{})
 		if err != nil {
-			return nil, errors.Wrap(err, "failed to read license")
+			return nil, fmt.Errorf("failed to read license from proxy, err: %w", err)
+		}
+		if resp.Response.License == "" {
+			return nil, errors.New("missing license from proxy")
 		}
 		licenseBytes = []byte(resp.Response.License)
 	} else if err != nil {
-		return nil, errors.Wrap(err, "failed to read license")
+		return nil, fmt.Errorf("failed to read license from file, err: %w", err)
 	}
 	return licenseBytes, nil
 }

lib.go

@@ -200,7 +200,7 @@ func VerifyLicense(opts Options) (v1alpha1.License, error) {
 func BadLicense(err error) (v1alpha1.License, error) {
 	if err == nil {
 		// This should never happen
-		panic(err)
+		panic("bad license: expected error")
 	}
 	return v1alpha1.License{
 		TypeMeta: metav1.TypeMeta{