Skip to content

Commit c360db0

Browse files
committed
Added feature flag for enabling window dimensions as part of state. Only when its enabled will the appsmith state object have a ui object. Currently setting it as true.
1 parent 1099d28 commit c360db0

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

app/client/src/ce/entities/FeatureFlag.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ export const FEATURE_FLAG = {
6464
"release_jsobjects_onpageunloadactions_enabled",
6565
configure_block_event_tracking_for_anonymous_users:
6666
"configure_block_event_tracking_for_anonymous_users",
67+
release_window_dimensions_enabled: "release_window_dimensions_enabled",
6768
} as const;
6869

6970
export type FeatureFlag = keyof typeof FEATURE_FLAG;
@@ -116,6 +117,7 @@ export const DEFAULT_FEATURE_FLAG_VALUE: FeatureFlags = {
116117
license_ai_agent_instance_enabled: false,
117118
release_jsobjects_onpageunloadactions_enabled: false,
118119
configure_block_event_tracking_for_anonymous_users: false,
120+
release_window_dimensions_enabled: true,
119121
};
120122

121123
export const AB_TESTING_EVENT_KEYS = {
Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
import type { DefaultRootState } from "react-redux";
2+
import { selectFeatureFlagCheck } from "ee/selectors/featureFlagsSelectors";
3+
import { FEATURE_FLAG } from "ee/entities/FeatureFlag";
24

35
export const getWindowDimensions = (state: DefaultRootState) => {
4-
return state.ui.windowDimensions;
6+
const isWindowDimensionsEnabled = selectFeatureFlagCheck(
7+
state,
8+
FEATURE_FLAG.release_window_dimensions_enabled,
9+
);
10+
11+
return isWindowDimensionsEnabled ? state.ui.windowDimensions : undefined;
512
};

0 commit comments

Comments
 (0)