Skip to content

Conversation

@lightmark
Copy link
Contributor

Description

change some functions with Object as the first parameter to self.

How Has This Been Tested?

unit test

@lightmark lightmark requested a review from wrwg as a code owner December 1, 2025 17:23
@cursor
Copy link

cursor bot commented Dec 1, 2025

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 7.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@lightmark lightmark enabled auto-merge (squash) December 1, 2025 17:23
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@lightmark lightmark force-pushed the lightmark/change_to_self branch from 0d7623c to aa01c5d Compare December 1, 2025 18:50
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

✅ Forge suite compat success on 92c0534410a26cafa4509b2dfda12c86811abf0a ==> b45b6944c29ea982aa115bb9e06e10f57f169d45

Compatibility test results for 92c0534410a26cafa4509b2dfda12c86811abf0a ==> b45b6944c29ea982aa115bb9e06e10f57f169d45 (PR)
1. Check liveness of validators at old version: 92c0534410a26cafa4509b2dfda12c86811abf0a
compatibility::simple-validator-upgrade::liveness-check : committed: 13588.15 txn/s, latency: 2555.46 ms, (p50: 2700 ms, p70: 2800, p90: 3300 ms, p99: 3900 ms), latency samples: 447760
2. Upgrading first Validator to new version: b45b6944c29ea982aa115bb9e06e10f57f169d45
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6147.86 txn/s, latency: 5521.83 ms, (p50: 6200 ms, p70: 6200, p90: 6300 ms, p99: 6400 ms), latency samples: 213360
3. Upgrading rest of first batch to new version: b45b6944c29ea982aa115bb9e06e10f57f169d45
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6006.77 txn/s, latency: 5658.16 ms, (p50: 6200 ms, p70: 6300, p90: 6500 ms, p99: 6600 ms), latency samples: 207260
4. upgrading second batch to new version: b45b6944c29ea982aa115bb9e06e10f57f169d45
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 5591.24 txn/s, latency: 5713.53 ms, (p50: 3600 ms, p70: 5900, p90: 13200 ms, p99: 15600 ms), latency samples: 214500
5. check swarm health
Compatibility test for 92c0534410a26cafa4509b2dfda12c86811abf0a ==> b45b6944c29ea982aa115bb9e06e10f57f169d45 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

✅ Forge suite realistic_env_max_load success on b45b6944c29ea982aa115bb9e06e10f57f169d45

Forge report malformed: Expecting property name enclosed in double quotes: line 2 column 1 (char 2)
'{\n[2025-12-01T21:52:24Z INFO  aptos_forge::report] Test Ok\n  "metrics": [\n    {\n      "test_name": "two traffics test: inner traffic",\n      "metric": "submitted_txn",\n      "value": 5033660.0\n    },\n    {\n      "test_name": "two traffics test: inner traffic",\n      "metric": "expired_txn",\n      "value": 0.0\n    },\n    {\n      "test_name": "two traffics test: inner traffic",\n      "metric": "avg_tps",\n      "value": 13518.014769910205\n    },\n    {\n      "test_name": "two traffics test: inner traffic",\n      "metric": "avg_latency",\n      "value": 2787.5446502147543\n    },\n    {\n      "test_name": "two traffics test: inner traffic",\n      "metric": "p50_latency",\n      "value": 2700.0\n    },\n    {\n      "test_name": "two traffics test: inner traffic",\n      "metric": "p90_latency",\n      "value": 3000.0\n    },\n    {\n      "test_name": "two traffics test: inner traffic",\n      "metric": "p99_latency",\n      "value": 3600.0\n    },\n    {\n      "test_name": "two traffics test",\n      "metric": "submitted_txn",\n      "value": 42680.0\n    },\n    {\n      "test_name": "two traffics test",\n      "metric": "expired_txn",\n      "value": 0.0\n    },\n    {\n      "test_name": "two traffics test",\n      "metric": "avg_tps",\n      "value": 99.99791150730215\n    },\n    {\n      "test_name": "two traffics test",\n      "metric": "avg_latency",\n      "value": 755.5193181818182\n    },\n    {\n      "test_name": "two traffics test",\n      "metric": "p50_latency",\n      "value": 700.0\n    },\n    {\n      "test_name": "two traffics test",\n      "metric": "p90_latency",\n      "value": 900.0\n    },\n    {\n      "test_name": "two traffics test",\n      "metric": "p99_latency",\n      "value": 2100.0\n    }\n  ],\n  "text": "two traffics test: inner traffic : committed: 13518.01 txn/s, latency: 2787.54 ms, (p50: 2700 ms, p70: 2900, p90: 3000 ms, p99: 3600 ms), latency samples: 5033660\\ntwo traffics test : committed: 100.00 txn/s, latency: 755.52 ms, (p50: 700 ms, p70: 800, p90: 900 ms, p99: 2100 ms), latency samples: 1760\\nLatency breakdown for phase 0: [\\"MempoolToBlockCreation: max: 2.264, avg: 2.174\\", \\"ConsensusProposalToOrdered: max: 0.168, avg: 0.165\\", \\"ConsensusOrderedToCommit: max: 0.064, avg: 0.056\\", \\"ConsensusProposalToCommit: max: 0.230, avg: 0.222\\"]\\nMax non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.49s no progress at version 5179030 (avg 0.07s) [limit 15].\\nMax epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.26s no progress at version 2477653 (avg 0.26s) [limit 16].\\nTest Ok"\n}'
Trailing Log Lines:
networkchaos.chaos-mesh.org "4-gcp--as-southeast1-to-3-gcp--us-east4-netem" deleted
test CompositeNetworkTest ... ok
Test Statistics: 
two traffics test: inner traffic : committed: 13518.01 txn/s, latency: 2787.54 ms, (p50: 2700 ms, p70: 2900, p90: 3000 ms, p99: 3600 ms), latency samples: 5033660
two traffics test : committed: 100.00 txn/s, latency: 755.52 ms, (p50: 700 ms, p70: 800, p90: 900 ms, p99: 2100 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.264, avg: 2.174", "ConsensusProposalToOrdered: max: 0.168, avg: 0.165", "ConsensusOrderedToCommit: max: 0.064, avg: 0.056", "ConsensusProposalToCommit: max: 0.230, avg: 0.222"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.49s no progress at version 5179030 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.26s no progress at version 2477653 (avg 0.26s) [limit 16].
Test Ok

=== BEGIN JUNIT ===
<?xml version="1.0" encoding="UTF-8"?>
<testsuites name="forge" tests="1" failures="0" errors="0" uuid="c72b1932-294b-44a5-9661-f4c08583dbbe">
    <testsuite name="local" tests="1" disabled="0" errors="0" failures="0">
        <testcase name="CompositeNetworkTest(network:multi-region-network-emulation(two traffics test)) with ">
        </testcase>
    </testsuite>
</testsuites>
=== END JUNIT ===
[2025-12-01T21:52:25Z INFO  aptos_forge::backend::k8s::cluster_helper] Deleting namespace forge-e2e-pr-18222: Some(NamespaceStatus { conditions: None, phase: Some("Terminating") })
[2025-12-01T21:52:25Z INFO  aptos_forge::backend::k8s::cluster_helper] aptos-node resources for Forge removed in namespace: forge-e2e-pr-18222

test result: ok. 1 passed; 0 soft failed; 0 hard failed; 0 filtered out

Debugging output:
NAME                                         READY   STATUS      RESTARTS   AGE
aptos-node-0-fullnode-eforgeba28ca14-0       1/1     Running     0          12m
aptos-node-0-validator-0                     1/1     Running     0          12m
aptos-node-1-fullnode-eforgeba28ca14-0       1/1     Running     0          12m
aptos-node-1-validator-0                     1/1     Running     0          12m
aptos-node-2-fullnode-eforgeba28ca14-0       1/1     Running     0          12m
aptos-node-2-validator-0                     1/1     Running     0          12m
aptos-node-3-fullnode-eforgeba28ca14-0       1/1     Running     0          12m
aptos-node-3-validator-0                     1/1     Running     0          12m
aptos-node-4-fullnode-eforgeba28ca14-0       1/1     Running     0          12m
aptos-node-4-validator-0                     1/1     Running     0          12m
aptos-node-5-validator-0                     1/1     Running     0          12m
aptos-node-6-validator-0                     1/1     Running     0          12m
forge-testnet-deployer-8s5w4                 0/1     Completed   0          12m
genesis-aptos-genesis-eforgeba28ca14-ntkx4   0/1     Completed   0          12m

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

✅ Forge suite framework_upgrade success on 92c0534410a26cafa4509b2dfda12c86811abf0a ==> b45b6944c29ea982aa115bb9e06e10f57f169d45

Compatibility test results for 92c0534410a26cafa4509b2dfda12c86811abf0a ==> b45b6944c29ea982aa115bb9e06e10f57f169d45 (PR)
Upgrade the nodes to version: b45b6944c29ea982aa115bb9e06e10f57f169d45
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2197.37 txn/s, submitted: 2204.88 txn/s, failed submission: 7.51 txn/s, expired: 7.51 txn/s, latency: 1318.29 ms, (p50: 1200 ms, p70: 1500, p90: 1800 ms, p99: 2400 ms), latency samples: 199041
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2243.61 txn/s, submitted: 2248.66 txn/s, failed submission: 5.05 txn/s, expired: 5.05 txn/s, latency: 1310.92 ms, (p50: 1200 ms, p70: 1500, p90: 1700 ms, p99: 2700 ms), latency samples: 204260
5. check swarm health
Compatibility test for 92c0534410a26cafa4509b2dfda12c86811abf0a ==> b45b6944c29ea982aa115bb9e06e10f57f169d45 passed
Upgrade the remaining nodes to version: b45b6944c29ea982aa115bb9e06e10f57f169d45
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2356.72 txn/s, submitted: 2364.47 txn/s, failed submission: 7.75 txn/s, expired: 7.75 txn/s, latency: 1298.50 ms, (p50: 1200 ms, p70: 1500, p90: 1700 ms, p99: 1800 ms), latency samples: 206842
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants