update RuboCop, configure new rules, and apply requested code style changes

Author: mojavelinux

.rubocop.yml

@@ -3,10 +3,8 @@ require:
 - rubocop-rspec
 AllCops:
   TargetRubyVersion: 2.7
-Capybara:
-  Enabled: false
-FactoryBot:
-  Enabled: false
+Gemspec/AddRuntimeDependency:
+  Enabled: true
 Gemspec/DeprecatedAttributeAssignment:
   Enabled: true
 Gemspec/DevelopmentDependencies:
@@ -93,6 +91,8 @@ Lint/DuplicateRequire:
   Enabled: true
 Lint/DuplicateRescueException:
   Enabled: true
+Lint/DuplicateSetElement:
+  Enabled: true
 Lint/EmptyBlock:
   Enabled: true
 Lint/EmptyClass:
@@ -111,8 +111,12 @@ Lint/IdentityComparison:
   Enabled: true
 Lint/IncompatibleIoSelectWithFiberScheduler:
   Enabled: true
+Lint/ItWithoutArgumentsInBlock:
+  Enabled: true
 Lint/LambdaWithoutLiteralBlock:
   Enabled: true
+Lint/LiteralAssignmentInCondition:
+  Enabled: true
 Lint/MissingSuper:
   Enabled: true
 Lint/MixedCaseRange:
@@ -159,6 +163,8 @@ Lint/TrailingCommaInAttributeDeclaration:
   Enabled: true
 Lint/TripleQuotes:
   Enabled: true
+Lint/UnescapedBracketInRegexp:
+  Enabled: true
 Lint/UnexpectedBlockArity:
   Enabled: true
 Lint/UnmodifiedReduceAccumulator:
@@ -169,6 +175,8 @@ Lint/UnusedMethodArgument:
   Enabled: true
 Lint/UselessMethodDefinition:
   Enabled: true
+Lint/UselessNumericOperation:
+  Enabled: true
 Lint/UselessRescue:
   Enabled: true
 Lint/UselessRuby2Keywords:
@@ -254,7 +262,7 @@ RSpec/ExcessiveDocstringSpacing:
   Enabled: true
 RSpec/ExpectInHook:
   Enabled: true
-RSpec/FilePath:
+RSpec/SpecFilePathFormat:
   Enabled: false
 RSpec/IdenticalEqualityAssertion:
   Enabled: true
@@ -273,8 +281,6 @@ RSpec/Pending:
   Enabled: true
 RSpec/PendingWithoutReason:
   Enabled: true
-RSpec/Rails:
-  Enabled: false
 RSpec/ReceiveMessages:
   Enabled: true
 RSpec/RedundantAround:
@@ -283,6 +289,8 @@ RSpec/SkipBlockInsideExample:
   Enabled: true
 RSpec/SortMetadata:
   Enabled: true
+RSpec/StringAsInstanceDoubleConstant:
+  Enabled: true
 RSpec/SubjectDeclaration:
   Enabled: true
 RSpec/VerifiedDoubleReference:
@@ -301,6 +309,8 @@ Style/AccessorGrouping:
 Style/Alias:
   Enabled: true
   EnforcedStyle: prefer_alias
+Style/AmbiguousEndlessMethodDefinition:
+  Enabled: true
 Style/ArgumentsForwarding:
   Enabled: true
 Style/ArrayCoercion:
@@ -313,6 +323,8 @@ Style/Attr:
   Enabled: true
 Style/BisectedAttrAccessor:
   Enabled: true
+Style/BitwisePredicate:
+  Enabled: true
 Style/BlockComments:
   Enabled: true
 Style/BlockDelimiters:
@@ -329,6 +341,8 @@ Style/ClassVars:
   Enabled: false # reason: an important language feature
 Style/CollectionCompact:
   Enabled: true
+Style/CombinableDefined:
+  Enabled: true
 Style/CombinableLoops:
   Enabled: true
 Style/CommandLiteral:
@@ -419,12 +433,16 @@ Style/InPatternThen:
   Enabled: true
 Style/InfiniteLoop:
   Enabled: false # reason: loop is measurably slower than while true
+Style/KeywordArgumentsMerging:
+  Enabled: true
 Style/KeywordParametersOrder:
   Enabled: true
 Style/MagicCommentFormat:
   Enabled: true
 Style/MapCompactWithConditionalBlock:
   Enabled: true
+Style/MapIntoArray:
+  Enabled: true
 Style/MapToHash:
   Enabled: false # reason: not supported in JRuby < 9.3
 Style/MapToSet:
@@ -513,6 +531,8 @@ Style/RedundantHeredocDelimiterQuotes:
   Enabled: false # reason: we want to be explicit about when no interpolation should be performed
 Style/RedundantInitialize:
   Enabled: true
+Style/RedundantInterpolationUnfreeze:
+  Enabled: true
 Style/RedundantLineContinuation:
   Enabled: true
 Style/RedundantPercentQ:
@@ -544,10 +564,16 @@ Style/MissingRespondToMissing:
   Enabled: true
 Style/SafeNavigation:
   Enabled: true
+Style/SafeNavigationChainLength:
+  Enabled: true
 Style/SelectByRegexp:
   Enabled: true
+Style/SendWithLiteralMethodName:
+  Enabled: true
 Style/SingleArgumentDig:
   Enabled: true
+Style/SingleLineDoEndBlock:
+  Enabled: true
 Style/SlicingWithRange:
   Enabled: false # reason: not supported in JRuby < 9.3
 Style/SoleNestedConditional:
@@ -561,6 +587,10 @@ Style/StringChars:
   Enabled: true
 Style/StringConcatenation:
   Enabled: false # reason: string concatenation can be faster
+Style/SuperArguments:
+  Enabled: true
+Style/SuperWithArgsParentheses:
+  Enabled: true
 Style/SwapValues:
   Enabled: true
 Style/SymbolArray:

Gemfile

@@ -10,7 +10,7 @@ group :coverage do
 end
 
 group :lint do
-  gem 'rubocop', '~> 1.55.0', require: false
+  gem 'rubocop', '~> 1.68.0', require: false
   gem 'rubocop-rake', '~> 0.6.0', require: false
-  gem 'rubocop-rspec', '~> 2.23.0', require: false
+  gem 'rubocop-rspec', '~> 3.2.0', require: false
 end

spec/spec_helper.rb

@@ -16,7 +16,7 @@
 RSpec.configure do
   def create_class super_class = Object, &block
     klass = Class.new super_class, &block
-    Object.const_set %(AnonymousClass#{klass.object_id}).to_sym, klass
+    Object.const_set :"AnonymousClass#{klass.object_id}", klass
     klass
   end
 

spec/tabs_spec.rb

@@ -482,7 +482,7 @@
     it 'should use anchor for tab ID if converter does not support id property on list item' do
       backend = nil
       create_class (Asciidoctor::Converter.for 'html5') do
-        register_for (backend = %(#{object_id}html5).to_sym)
+        register_for (backend = :"#{object_id}html5")
         def convert_ulist node
           super.gsub %r/<li id="[^"]+"/, '<li'
         end