chore: hoist pty-multiplex to run module (#888)

Hoists pty-multiplex to aspect-extensions/run since it does not belong
with core.
Explicit redirect follow up to 10 times and propagate http errors to
callsite.

Author: thesayyn

Cargo.lock

@@ -22,7 +22,7 @@ starlark_map = "0.13.0"
 anyhow = "1.0.98"
 thiserror = "2.0.12"
 
-reqwest = { version="0.12.22", features = ["stream"] }
+reqwest = { version="0.12.22", features = ["stream", "gzip", "zstd"] }
 prost = "0.14.1"
 zstd = "0.13.3"
 

crates/axl-runtime/Cargo.toml

@@ -2,6 +2,7 @@ use allocative::Allocative;
 use derive_more::Display;
 use futures::FutureExt;
 use futures::TryStreamExt;
+use reqwest::redirect::Policy;
 use starlark::environment::{Methods, MethodsBuilder, MethodsStatic};
 use starlark::values::dict::UnpackDictEntries;
 use starlark::values::AllocValue;
@@ -24,7 +25,12 @@ pub struct Http {
 impl Http {
     pub fn new() -> Self {
         Self {
-            client: reqwest::Client::new(),
+            client: reqwest::Client::builder()
+                .user_agent("AXL-Runtime")
+                // This is the default but lets be explicit.
+                .redirect(Policy::limited(10))
+                .build()
+                .expect("failed to build the http client"),
         }
     }
 }
@@ -56,7 +62,7 @@ pub(crate) fn http_methods(registry: &mut MethodsBuilder) {
         }
 
         let fut = async move {
-            let res = req.send().await?;
+            let res = req.send().await?.error_for_status()?;
             let mut file = OpenOptions::new()
                 .create(true)
                 .write(true)

crates/axl-runtime/src/engine/http.rs

@@ -136,16 +136,17 @@ impl<'v> values::StarlarkValue<'v> for WasmCallable {
         let mut outputs: Vec<wasmi::Val> = vec![];
         let heap = eval.heap();
 
-        let positionals = if ty.params().is_empty() {
+        let positionals = if !ty.params().is_empty() {
             use starlark::__derive_refs::{
                 parse_args::{check_required, parse_signature},
                 sig::parameter_spec,
             };
             let __args: [_; 1] = parse_signature(
-                &parameter_spec("get_memory", &[], &[], true, &[], false),
+                &parameter_spec("args", &[], &[], true, &[], false),
                 args,
                 eval.heap(),
             )?;
+
             let positionals: UnpackTuple<Value<'v>> = check_required("args", __args[0])?;
 
             positionals.items